[webkit-changes] [185249] trunk

Fri, 05 Jun 2015 10:08:32 -0700

Title: [185249] trunk
Revision
185249
Author
[email protected]
Date
2015-06-05 10:08:18 -0700 (Fri, 05 Jun 2015)

Log Message

[Mac] Popup focus is cut off
https://bugs.webkit.org/show_bug.cgi?id=145688
<rdar://problem/18313375>

Reviewed by Brent Fulgham.

Source/WebCore:

Yosemite increased the width of focus rings, causing
some ugly clipping on Yosemite. The solution was to
not set a clip (which was code introduced for Leopard).

Test: fast/forms/select-element-focus-ring.html

* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintMenuList): Don't clip on Yosemite.

LayoutTests:

* fast/forms/select-element-focus-ring.html: Added.
* platform/mac/fast/forms/select-element-focus-ring-expected.png: Added.
* platform/mac/fast/forms/select-element-focus-ring-expected.txt: Added.

Modified Paths

Added Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (185248 => 185249)


--- trunk/LayoutTests/ChangeLog	2015-06-05 16:50:51 UTC (rev 185248)
+++ trunk/LayoutTests/ChangeLog	2015-06-05 17:08:18 UTC (rev 185249)
@@ -1,3 +1,15 @@
+2015-06-05  Dean Jackson  <[email protected]>
+
+        [Mac] Popup focus is cut off
+        https://bugs.webkit.org/show_bug.cgi?id=145688
+        <rdar://problem/18313375>
+
+        Reviewed by Brent Fulgham.
+
+        * fast/forms/select-element-focus-ring.html: Added.
+        * platform/mac/fast/forms/select-element-focus-ring-expected.png: Added.
+        * platform/mac/fast/forms/select-element-focus-ring-expected.txt: Added.
+
 2015-06-05  Brent Fulgham  <[email protected]>
 
         Add WK1 versions of tests from Bugs 145637 and 145642

Added: trunk/LayoutTests/fast/forms/select-element-focus-ring.html (0 => 185249)


--- trunk/LayoutTests/fast/forms/select-element-focus-ring.html	                        (rev 0)
+++ trunk/LayoutTests/fast/forms/select-element-focus-ring.html	2015-06-05 17:08:18 UTC (rev 185249)
@@ -0,0 +1,25 @@
+<script>
+window.addEventListener("load", function () {
+  document.querySelector("select").focus();
+}, false);
+</script>
+<select>
+  <option>banana</option>
+  <option>papaya</option>
+  <option>orange</option>
+  <option>banana</option>
+  <option>papaya</option>
+  <option>orange</option>
+  <option>banana</option>
+  <option>papaya</option>
+  <option>orange</option>
+  <option>banana</option>
+  <option>papaya</option>
+  <option>orange</option>
+  <option>banana</option>
+  <option>papaya</option>
+  <option>orange</option>
+  <option>banana</option>
+  <option>papaya</option>
+  <option>orange</option>
+</select>
Property changes on: trunk/LayoutTests/fast/forms/select-element-focus-ring.html
___________________________________________________________________

Added: svn:mime-type

Added: svn:keywords

Added: svn:eol-style

Added: trunk/LayoutTests/platform/mac/fast/forms/select-element-focus-ring-expected.png


(Binary files differ)
Property changes on: trunk/LayoutTests/platform/mac/fast/forms/select-element-focus-ring-expected.png ___________________________________________________________________

Added: svn:mime-type

Added: trunk/LayoutTests/platform/mac/fast/forms/select-element-focus-ring-expected.txt (0 => 185249)


--- trunk/LayoutTests/platform/mac/fast/forms/select-element-focus-ring-expected.txt	                        (rev 0)
+++ trunk/LayoutTests/platform/mac/fast/forms/select-element-focus-ring-expected.txt	2015-06-05 17:08:18 UTC (rev 185249)
@@ -0,0 +1,10 @@
+layer at (0,0) size 800x600
+  RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+  RenderBlock {HTML} at (0,0) size 800x600
+    RenderBody {BODY} at (8,8) size 784x584
+      RenderMenuList {SELECT} at (2,2) size 70x18 [bgcolor=#FFFFFF]
+        RenderBlock (anonymous) at (0,0) size 70x18
+          RenderText at (8,2) size 39x13
+            text run at (8,2) width 39: "banana"
+      RenderText {#text} at (0,0) size 0x0
Property changes on: trunk/LayoutTests/platform/mac/fast/forms/select-element-focus-ring-expected.txt
___________________________________________________________________

Added: svn:mime-type

Added: svn:keywords

Added: svn:eol-style

Modified: trunk/Source/WebCore/ChangeLog (185248 => 185249)


--- trunk/Source/WebCore/ChangeLog	2015-06-05 16:50:51 UTC (rev 185248)
+++ trunk/Source/WebCore/ChangeLog	2015-06-05 17:08:18 UTC (rev 185249)
@@ -1,3 +1,20 @@
+2015-06-05  Dean Jackson  <[email protected]>
+
+        [Mac] Popup focus is cut off
+        https://bugs.webkit.org/show_bug.cgi?id=145688
+        <rdar://problem/18313375>
+
+        Reviewed by Brent Fulgham.
+
+        Yosemite increased the width of focus rings, causing
+        some ugly clipping on Yosemite. The solution was to
+        not set a clip (which was code introduced for Leopard).
+
+        Test: fast/forms/select-element-focus-ring.html
+
+        * rendering/RenderThemeMac.mm:
+        (WebCore::RenderThemeMac::paintMenuList): Don't clip on Yosemite.
+
 2015-06-05  Manuel Rego Casasnovas  <[email protected]>
 
         [CSS Grid Layout] Support dots sequences in grid-template-areas

Modified: trunk/Source/WebCore/rendering/RenderThemeMac.mm (185248 => 185249)


--- trunk/Source/WebCore/rendering/RenderThemeMac.mm	2015-06-05 16:50:51 UTC (rev 185248)
+++ trunk/Source/WebCore/rendering/RenderThemeMac.mm	2015-06-05 17:08:18 UTC (rev 185249)
@@ -929,8 +929,10 @@
 
     GraphicsContextStateSaver stateSaver(*paintInfo.context);
 
-    // On Leopard, the cell will draw outside of the given rect, so we have to clip to the rect
+    // Before Yosemite we did not want the cell to ever draw outside the given rectangle.
+#if __MAC_OS_X_VERSION_MIN_REQUIRED < 101000
     paintInfo.context->clip(inflatedRect);
+#endif
 
     if (zoomLevel != 1.0f) {
         inflatedRect.setWidth(inflatedRect.width() / zoomLevel);

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to