[webkit-changes] [185255] trunk/Source/WebInspectorUI

Fri, 05 Jun 2015 11:11:56 -0700

Title: [185255] trunk/Source/WebInspectorUI
Revision
185255
Author
[email protected]
Date
2015-06-05 11:11:32 -0700 (Fri, 05 Jun 2015)

Log Message

Web Inspector: Switch to doughnut chart and remove idle time in the Rendering Frames timeline
https://bugs.webkit.org/show_bug.cgi?id=145671

Reviewed by Timothy Hatcher.

* Localizations/en.lproj/localizedStrings.js:
"Idle" string no longer used.

* UserInterface/Views/TimelineRecordFrame.js:
Reduced maximum frame width by 2px.

* UserInterface/Views/TimelineSidebarPanel.js:
(WebInspector.TimelineSidebarPanel):
(WebInspector.TimelineSidebarPanel.prototype._refreshFrameSelectionChart):
Added inner radius to chart and removed "Idle" value.

Modified Paths

Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (185254 => 185255)


--- trunk/Source/WebInspectorUI/ChangeLog	2015-06-05 18:09:58 UTC (rev 185254)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-06-05 18:11:32 UTC (rev 185255)
@@ -1,3 +1,21 @@
+2015-06-05  Matt Baker  <[email protected]>
+
+        Web Inspector: Switch to doughnut chart and remove idle time in the Rendering Frames timeline
+        https://bugs.webkit.org/show_bug.cgi?id=145671
+
+        Reviewed by Timothy Hatcher.
+
+        * Localizations/en.lproj/localizedStrings.js:
+        "Idle" string no longer used.
+
+        * UserInterface/Views/TimelineRecordFrame.js:
+        Reduced maximum frame width by 2px.
+
+        * UserInterface/Views/TimelineSidebarPanel.js:
+        (WebInspector.TimelineSidebarPanel):
+        (WebInspector.TimelineSidebarPanel.prototype._refreshFrameSelectionChart):
+        Added inner radius to chart and removed "Idle" value.
+
 2015-06-04  Joseph Pecoraro  <[email protected]>
 
         Web Inspector: Class constructor appearing as Object Tree property does not include parameters

Modified: trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (185254 => 185255)


--- trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js	2015-06-05 18:09:58 UTC (rev 185254)
+++ trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js	2015-06-05 18:11:32 UTC (rev 185255)
@@ -259,7 +259,6 @@
 localizedStrings["Icon and Text (Horizontal)"] = "Icon and Text (Horizontal)";
 localizedStrings["Icon and Text (Vertical)"] = "Icon and Text (Vertical)";
 localizedStrings["Identity"] = "Identity";
-localizedStrings["Idle"] = "Idle";
 localizedStrings["Ignored"] = "Ignored";
 localizedStrings["Image"] = "Image";
 localizedStrings["Image Size"] = "Image Size";

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordFrame.js (185254 => 185255)


--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordFrame.js	2015-06-05 18:09:58 UTC (rev 185254)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordFrame.js	2015-06-05 18:11:32 UTC (rev 185255)
@@ -38,7 +38,7 @@
 // FIXME: Move to a WebInspector.Object subclass and we can remove this.
 WebInspector.Object.deprecatedAddConstructorFunctions(WebInspector.TimelineRecordFrame);
 
-WebInspector.TimelineRecordFrame.MaximumWidthPixels = 16;
+WebInspector.TimelineRecordFrame.MaximumWidthPixels = 14;
 WebInspector.TimelineRecordFrame.MinimumWidthPixels = 4;
 
 WebInspector.TimelineRecordFrame.prototype = {

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.js (185254 => 185255)


--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.js	2015-06-05 18:09:58 UTC (rev 185254)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.js	2015-06-05 18:11:32 UTC (rev 185255)
@@ -82,11 +82,11 @@
             this._chartColors = {
                 layout: "rgb(212, 108, 108)",
                 script: "rgb(153, 113, 185)",
-                other: "rgb(221, 221, 221)",
-                idle: "rgb(255, 255, 255)"
+                other: "rgb(221, 221, 221)"
             };
 
             this._frameSelectionChartRow = new WebInspector.ChartDetailsSectionRow(this);
+            this._frameSelectionChartRow.innerRadius = 0.5;
 
             var chartGroup = new WebInspector.DetailsSectionGroup([this._frameSelectionChartRow]);
             this._frameSelectionChartSection = new WebInspector.DetailsSection("frames-selection-chart", WebInspector.UIString("Selected Frames"), [chartGroup], null, true);
@@ -793,8 +793,7 @@
             this._frameSelectionChartRow.data = [
                 {label: WebInspector.UIString("Layout"), value: 0, color: this._chartColors.layout},
                 {label: WebInspector.UIString("Script"), value: 0, color: this._chartColors.script},
-                {label: WebInspector.UIString("Other"), value: 0, color: this._chartColors.other},
-                {label: WebInspector.UIString("Idle"), value: 0, color: this._chartColors.idle}
+                {label: WebInspector.UIString("Other"), value: 0, color: this._chartColors.other}
             ];
             return;
         }
@@ -821,13 +820,11 @@
         var layoutTime = durationForRecordType(WebInspector.TimelineRecord.Type.Layout);
         var scriptTime = durationForRecordType(WebInspector.TimelineRecord.Type.Script);
         var otherTime = durationForRecordType();
-        var idleTime = totalTime - layoutTime - scriptTime - otherTime;
 
         this._frameSelectionChartRow.data = [
             {label: WebInspector.UIString("Layout"), value: layoutTime, color: this._chartColors.layout},
             {label: WebInspector.UIString("Script"), value: scriptTime, color: this._chartColors.script},
-            {label: WebInspector.UIString("Other"), value: otherTime, color: this._chartColors.other},
-            {label: WebInspector.UIString("Idle"), value: idleTime, color: this._chartColors.idle}
+            {label: WebInspector.UIString("Other"), value: otherTime, color: this._chartColors.other}
         ];
     }
 

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to