Title: [185267] trunk/Source/_javascript_Core
Revision
185267
Author
[email protected]
Date
2015-06-05 15:00:54 -0700 (Fri, 05 Jun 2015)

Log Message

speculateRealNumber() should early exit if you're already a real number, not if you're already a real double.

Rubber stamped by Mark Lam.
        
This was causing: https://build.webkit.org/results/Apple%20Yosemite%20Debug%20WK1%20(Tests)/r185261%20(5180)/webaudio/note-grain-on-timing-crash-log.txt

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::speculateRealNumber):

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (185266 => 185267)


--- trunk/Source/_javascript_Core/ChangeLog	2015-06-05 21:46:25 UTC (rev 185266)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-06-05 22:00:54 UTC (rev 185267)
@@ -1,3 +1,14 @@
+2015-06-05  Filip Pizlo  <[email protected]>
+
+        speculateRealNumber() should early exit if you're already a real number, not if you're already a real double.
+
+        Rubber stamped by Mark Lam.
+        
+        This was causing: https://build.webkit.org/results/Apple%20Yosemite%20Debug%20WK1%20(Tests)/r185261%20(5180)/webaudio/note-grain-on-timing-crash-log.txt
+
+        * dfg/DFGSpeculativeJIT.cpp:
+        (JSC::DFG::SpeculativeJIT::speculateRealNumber):
+
 2015-06-05  Mark Lam  <[email protected]>
 
         finally blocks should not set the exception stack trace when re-throwing the exception.

Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp (185266 => 185267)


--- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp	2015-06-05 21:46:25 UTC (rev 185266)
+++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp	2015-06-05 22:00:54 UTC (rev 185267)
@@ -5405,7 +5405,7 @@
 
 void SpeculativeJIT::speculateRealNumber(Edge edge)
 {
-    if (!needsTypeCheck(edge, SpecDoubleReal))
+    if (!needsTypeCheck(edge, SpecBytecodeRealNumber))
         return;
     
     JSValueOperand op1(this, edge, ManualOperandSpeculation);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to