Title: [185286] trunk
- Revision
- 185286
- Author
- [email protected]
- Date
- 2015-06-06 00:55:21 -0700 (Sat, 06 Jun 2015)
Log Message
Returned Exception* values need to be initialized to nullptr when no exceptions are thrown.
https://bugs.webkit.org/show_bug.cgi?id=145720
Reviewed by Dan Bernstein.
Source/_javascript_Core:
* debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::evaluate):
Source/WebCore:
No new tests because this issue is already covered by the existing inspector-protocol tests.
* bindings/js/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::evaluate):
LayoutTests:
* platform/win/TestExpectations:
- Undoing skipped tests.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (185285 => 185286)
--- trunk/LayoutTests/ChangeLog 2015-06-06 04:40:18 UTC (rev 185285)
+++ trunk/LayoutTests/ChangeLog 2015-06-06 07:55:21 UTC (rev 185286)
@@ -1,3 +1,13 @@
+2015-06-06 Mark Lam <[email protected]>
+
+ Returned Exception* values need to be initialized to nullptr when no exceptions are thrown.
+ https://bugs.webkit.org/show_bug.cgi?id=145720
+
+ Reviewed by Dan Bernstein.
+
+ * platform/win/TestExpectations:
+ - Undoing skipped tests.
+
2015-06-05 Mark Lam <[email protected]>
Gardening: skip some inspector-protocol tests while the issue is being investigated.
Modified: trunk/LayoutTests/platform/win/TestExpectations (185285 => 185286)
--- trunk/LayoutTests/platform/win/TestExpectations 2015-06-06 04:40:18 UTC (rev 185285)
+++ trunk/LayoutTests/platform/win/TestExpectations 2015-06-06 07:55:21 UTC (rev 185286)
@@ -2369,14 +2369,6 @@
inspector-protocol/debugger/removeBreakpoint.html [ Skip ] # Crashing
inspector-protocol/debugger/searchInContent-linebreaks.html [ Pass Crash ] # Flaky
-webkit.org/b/145720 [ Release ] inspector-protocol/debugger/didSampleProbe-multiple-probes.html [ Skip ]
-webkit.org/b/145720 [ Release ] inspector-protocol/debugger/hit-breakpoint-from-console.html [ Skip ]
-webkit.org/b/145720 [ Release ] inspector-protocol/debugger/setBreakpoint-condition.html [ Skip ]
-webkit.org/b/145720 [ Release ] inspector-protocol/debugger/breakpoint-inside-conditons-and-actions.html [ Failure ]
-webkit.org/b/145720 [ Release ] inspector-protocol/debugger/setBreakpoint-actions.html [ Failure ]
-webkit.org/b/145720 [ Release ] inspector-protocol/debugger/setBreakpoint-column.html [ Failure ]
-webkit.org/b/145720 [ Release ] inspector-protocol/debugger/setBreakpointByUrl-sourceURL.html [ Failure ]
-
webkit.org/b/143548 inspector/console/console-api.html [ Skip ] # Timeout
################################################################################
################# End Inspector Issues ####################
Modified: trunk/Source/_javascript_Core/ChangeLog (185285 => 185286)
--- trunk/Source/_javascript_Core/ChangeLog 2015-06-06 04:40:18 UTC (rev 185285)
+++ trunk/Source/_javascript_Core/ChangeLog 2015-06-06 07:55:21 UTC (rev 185286)
@@ -1,3 +1,13 @@
+2015-06-06 Mark Lam <[email protected]>
+
+ Returned Exception* values need to be initialized to nullptr when no exceptions are thrown.
+ https://bugs.webkit.org/show_bug.cgi?id=145720
+
+ Reviewed by Dan Bernstein.
+
+ * debugger/DebuggerCallFrame.cpp:
+ (JSC::DebuggerCallFrame::evaluate):
+
2015-06-05 Mark Lam <[email protected]>
Subclasses of JSNonFinalObject with gc'able children need to implement visitChildren().
Modified: trunk/Source/_javascript_Core/debugger/DebuggerCallFrame.cpp (185285 => 185286)
--- trunk/Source/_javascript_Core/debugger/DebuggerCallFrame.cpp 2015-06-06 04:40:18 UTC (rev 185285)
+++ trunk/Source/_javascript_Core/debugger/DebuggerCallFrame.cpp 2015-06-06 07:55:21 UTC (rev 185286)
@@ -180,6 +180,7 @@
JSValue DebuggerCallFrame::evaluate(const String& script, Exception*& exception)
{
ASSERT(isValid());
+ exception = nullptr;
CallFrame* callFrame = m_callFrame;
if (!callFrame)
return jsNull();
Modified: trunk/Source/WebCore/ChangeLog (185285 => 185286)
--- trunk/Source/WebCore/ChangeLog 2015-06-06 04:40:18 UTC (rev 185285)
+++ trunk/Source/WebCore/ChangeLog 2015-06-06 07:55:21 UTC (rev 185286)
@@ -1,3 +1,15 @@
+2015-06-06 Mark Lam <[email protected]>
+
+ Returned Exception* values need to be initialized to nullptr when no exceptions are thrown.
+ https://bugs.webkit.org/show_bug.cgi?id=145720
+
+ Reviewed by Dan Bernstein.
+
+ No new tests because this issue is already covered by the existing inspector-protocol tests.
+
+ * bindings/js/WorkerScriptController.cpp:
+ (WebCore::WorkerScriptController::evaluate):
+
2015-06-05 Andreas Kling <[email protected]>
[iOS] Don't force compositing layers for no-op 3D transforms on low-memory devices.
Modified: trunk/Source/WebCore/bindings/js/WorkerScriptController.cpp (185285 => 185286)
--- trunk/Source/WebCore/bindings/js/WorkerScriptController.cpp 2015-06-06 04:40:18 UTC (rev 185285)
+++ trunk/Source/WebCore/bindings/js/WorkerScriptController.cpp 2015-06-06 07:55:21 UTC (rev 185286)
@@ -109,6 +109,7 @@
void WorkerScriptController::evaluate(const ScriptSourceCode& sourceCode, JSC::Exception*& returnedException)
{
+ returnedException = nullptr;
if (isExecutionForbidden())
return;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
