Title: [185291] trunk/Source/WebKit/mac
Revision
185291
Author
[email protected]
Date
2015-06-06 12:45:38 -0700 (Sat, 06 Jun 2015)

Log Message

Stop using _webkit_fixedCarbonPOSIXPath in plug-in code
https://bugs.webkit.org/show_bug.cgi?id=145728

Reviewed by Dan Bernstein.

This code was put in place to support old plug-ins that would pass Carbon paths to NPAPI functions.
WebKit2 never supported this and we've never had any problems so let's just get rid of it.

* Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::loadURL):
* Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView _postURL:target:len:buf:file:notifyData:sendNotification:allowHeaders:]):

Modified Paths

Diff

Modified: trunk/Source/WebKit/mac/ChangeLog (185290 => 185291)


--- trunk/Source/WebKit/mac/ChangeLog	2015-06-06 19:37:00 UTC (rev 185290)
+++ trunk/Source/WebKit/mac/ChangeLog	2015-06-06 19:45:38 UTC (rev 185291)
@@ -1,5 +1,20 @@
 2015-06-06  Anders Carlsson  <[email protected]>
 
+        Stop using _webkit_fixedCarbonPOSIXPath in plug-in code
+        https://bugs.webkit.org/show_bug.cgi?id=145728
+
+        Reviewed by Dan Bernstein.
+
+        This code was put in place to support old plug-ins that would pass Carbon paths to NPAPI functions.
+        WebKit2 never supported this and we've never had any problems so let's just get rid of it.
+
+        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
+        (WebKit::NetscapePluginInstanceProxy::loadURL):
+        * Plugins/WebNetscapePluginView.mm:
+        (-[WebNetscapePluginView _postURL:target:len:buf:file:notifyData:sendNotification:allowHeaders:]):
+
+2015-06-06  Anders Carlsson  <[email protected]>
+
         Remove SPI that's no longer used
         https://bugs.webkit.org/show_bug.cgi?id=145727
 

Modified: trunk/Source/WebKit/mac/Plugins/Hosted/NetscapePluginInstanceProxy.mm (185290 => 185291)


--- trunk/Source/WebKit/mac/Plugins/Hosted/NetscapePluginInstanceProxy.mm	2015-06-06 19:37:00 UTC (rev 185290)
+++ trunk/Source/WebKit/mac/Plugins/Hosted/NetscapePluginInstanceProxy.mm	2015-06-06 19:45:38 UTC (rev 185291)
@@ -580,7 +580,7 @@
                 path = [fileURL path];
             else
                 path = (NSString *)bufString.get();
-            httpBody = [NSData dataWithContentsOfFile:[path _webkit_fixedCarbonPOSIXPath]];
+            httpBody = [NSData dataWithContentsOfFile:path];
             if (!httpBody)
                 return NPERR_FILE_NOT_FOUND;
         } else

Modified: trunk/Source/WebKit/mac/Plugins/WebNetscapePluginView.mm (185290 => 185291)


--- trunk/Source/WebKit/mac/Plugins/WebNetscapePluginView.mm	2015-06-06 19:37:00 UTC (rev 185290)
+++ trunk/Source/WebKit/mac/Plugins/WebNetscapePluginView.mm	2015-06-06 19:45:38 UTC (rev 185291)
@@ -1803,7 +1803,7 @@
         } else {
             path = bufString;
         }
-        postData = [NSData dataWithContentsOfFile:[path _webkit_fixedCarbonPOSIXPath]];
+        postData = [NSData dataWithContentsOfFile:path];
         CFRelease(bufString);
         if (!postData) {
             return NPERR_FILE_NOT_FOUND;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to