Title: [185345] trunk/Tools
- Revision
- 185345
- Author
- [email protected]
- Date
- 2015-06-08 17:47:25 -0700 (Mon, 08 Jun 2015)
Log Message
Yet another unreviewed build fix :(
* Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
(OSXSafariDriver):
(OSXSafariDriver.launchUrl):
(OSXSafariDriver.closeBrowsers):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (185344 => 185345)
--- trunk/Tools/ChangeLog 2015-06-09 00:45:59 UTC (rev 185344)
+++ trunk/Tools/ChangeLog 2015-06-09 00:47:25 UTC (rev 185345)
@@ -1,5 +1,14 @@
2015-06-08 Ryosuke Niwa <[email protected]>
+ Yet another unreviewed build fix :(
+
+ * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
+ (OSXSafariDriver):
+ (OSXSafariDriver.launchUrl):
+ (OSXSafariDriver.closeBrowsers):
+
+2015-06-08 Ryosuke Niwa <[email protected]>
+
Unreviewed build fix. Initialize result in the case things blow up below.
* Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
Modified: trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py (185344 => 185345)
--- trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py 2015-06-09 00:45:59 UTC (rev 185344)
+++ trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py 2015-06-09 00:47:25 UTC (rev 185345)
@@ -13,6 +13,7 @@
class OSXSafariDriver(OSXBrowserDriver):
+ bundleIdentifier = 'com.apple.Safari'
def prepareEnv(self):
self.safariProcess = None
@@ -42,7 +43,6 @@
subprocess.Popen(['open', url])
def closeBrowsers(self):
- if self.safariProcess:
- self.terminateProcesses('com.apple.Safari')
- if self.safariProcess.returncode:
- _log.error('Safari Crashed!')
+ self.closeBrowsers()
+ if self.safariProcess and self.safariProcess.returncode:
+ sys.exit('Browser crashed with exitcode %d' % self._process.returncode)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
