Diff
Modified: trunk/Source/WebCore/ChangeLog (185422 => 185423)
--- trunk/Source/WebCore/ChangeLog 2015-06-10 17:42:47 UTC (rev 185422)
+++ trunk/Source/WebCore/ChangeLog 2015-06-10 18:15:23 UTC (rev 185423)
@@ -1,3 +1,33 @@
+2015-06-10 Chris Dumez <[email protected]>
+
+ Drop unused argument for Node::didNotifySubtreeInsertions()
+ https://bugs.webkit.org/show_bug.cgi?id=145845
+
+ Reviewed by Andreas Kling.
+
+ * dom/ContainerNodeAlgorithms.h:
+ (WebCore::ChildNodeInsertionNotifier::notify):
+ * dom/Node.h:
+ (WebCore::Node::didNotifySubtreeInsertions):
+ * html/HTMLFrameElementBase.cpp:
+ (WebCore::HTMLFrameElementBase::didNotifySubtreeInsertions):
+ * html/HTMLFrameElementBase.h:
+ * svg/SVGFEImageElement.cpp:
+ (WebCore::SVGFEImageElement::didNotifySubtreeInsertions):
+ * svg/SVGFEImageElement.h:
+ * svg/SVGMPathElement.cpp:
+ (WebCore::SVGMPathElement::didNotifySubtreeInsertions):
+ * svg/SVGMPathElement.h:
+ * svg/SVGTRefElement.cpp:
+ (WebCore::SVGTRefElement::didNotifySubtreeInsertions):
+ * svg/SVGTRefElement.h:
+ * svg/SVGTextPathElement.cpp:
+ (WebCore::SVGTextPathElement::didNotifySubtreeInsertions):
+ * svg/SVGTextPathElement.h:
+ * svg/animation/SVGSMILElement.cpp:
+ (WebCore::SVGSMILElement::didNotifySubtreeInsertions):
+ * svg/animation/SVGSMILElement.h:
+
2015-06-10 KwangHyuk Kim <[email protected]>
[EFL] Jpeg image export implementation for Canvas.
Modified: trunk/Source/WebCore/dom/ContainerNodeAlgorithms.h (185422 => 185423)
--- trunk/Source/WebCore/dom/ContainerNodeAlgorithms.h 2015-06-10 17:42:47 UTC (rev 185422)
+++ trunk/Source/WebCore/dom/ContainerNodeAlgorithms.h 2015-06-10 18:15:23 UTC (rev 185423)
@@ -227,7 +227,7 @@
notifyNodeInsertedIntoTree(downcast<ContainerNode>(node));
for (size_t i = 0; i < m_postInsertionNotificationTargets.size(); ++i)
- m_postInsertionNotificationTargets[i]->didNotifySubtreeInsertions(&m_insertionPoint);
+ m_postInsertionNotificationTargets[i]->didNotifySubtreeInsertions();
}
Modified: trunk/Source/WebCore/dom/Node.h (185422 => 185423)
--- trunk/Source/WebCore/dom/Node.h 2015-06-10 17:42:47 UTC (rev 185422)
+++ trunk/Source/WebCore/dom/Node.h 2015-06-10 18:15:23 UTC (rev 185423)
@@ -478,7 +478,7 @@
};
virtual InsertionNotificationRequest insertedInto(ContainerNode& insertionPoint);
- virtual void didNotifySubtreeInsertions(ContainerNode*) { }
+ virtual void didNotifySubtreeInsertions() { }
// Notifies the node that it is no longer part of the tree.
//
Modified: trunk/Source/WebCore/html/HTMLFrameElementBase.cpp (185422 => 185423)
--- trunk/Source/WebCore/html/HTMLFrameElementBase.cpp 2015-06-10 17:42:47 UTC (rev 185422)
+++ trunk/Source/WebCore/html/HTMLFrameElementBase.cpp 2015-06-10 18:15:23 UTC (rev 185423)
@@ -137,7 +137,7 @@
return InsertionDone;
}
-void HTMLFrameElementBase::didNotifySubtreeInsertions(ContainerNode*)
+void HTMLFrameElementBase::didNotifySubtreeInsertions()
{
if (!inDocument())
return;
Modified: trunk/Source/WebCore/html/HTMLFrameElementBase.h (185422 => 185423)
--- trunk/Source/WebCore/html/HTMLFrameElementBase.h 2015-06-10 17:42:47 UTC (rev 185422)
+++ trunk/Source/WebCore/html/HTMLFrameElementBase.h 2015-06-10 18:15:23 UTC (rev 185423)
@@ -52,7 +52,7 @@
virtual void parseAttribute(const QualifiedName&, const AtomicString&) override;
virtual InsertionNotificationRequest insertedInto(ContainerNode&) override final;
- virtual void didNotifySubtreeInsertions(ContainerNode*) override final;
+ virtual void didNotifySubtreeInsertions() override final;
virtual void didAttachRenderers() override;
private:
Modified: trunk/Source/WebCore/svg/SVGFEImageElement.cpp (185422 => 185423)
--- trunk/Source/WebCore/svg/SVGFEImageElement.cpp 2015-06-10 17:42:47 UTC (rev 185422)
+++ trunk/Source/WebCore/svg/SVGFEImageElement.cpp 2015-06-10 18:15:23 UTC (rev 185423)
@@ -146,7 +146,7 @@
return InsertionShouldCallDidNotifySubtreeInsertions;
}
-void SVGFEImageElement::didNotifySubtreeInsertions(ContainerNode*)
+void SVGFEImageElement::didNotifySubtreeInsertions()
{
buildPendingResource();
}
Modified: trunk/Source/WebCore/svg/SVGFEImageElement.h (185422 => 185423)
--- trunk/Source/WebCore/svg/SVGFEImageElement.h 2015-06-10 17:42:47 UTC (rev 185422)
+++ trunk/Source/WebCore/svg/SVGFEImageElement.h 2015-06-10 18:15:23 UTC (rev 185423)
@@ -45,7 +45,7 @@
private:
SVGFEImageElement(const QualifiedName&, Document&);
- virtual void didNotifySubtreeInsertions(ContainerNode*) override;
+ virtual void didNotifySubtreeInsertions() override;
virtual void parseAttribute(const QualifiedName&, const AtomicString&) override;
virtual void svgAttributeChanged(const QualifiedName&) override;
Modified: trunk/Source/WebCore/svg/SVGMPathElement.cpp (185422 => 185423)
--- trunk/Source/WebCore/svg/SVGMPathElement.cpp 2015-06-10 17:42:47 UTC (rev 185422)
+++ trunk/Source/WebCore/svg/SVGMPathElement.cpp 2015-06-10 18:15:23 UTC (rev 185423)
@@ -94,7 +94,7 @@
return InsertionDone;
}
-void SVGMPathElement::didNotifySubtreeInsertions(ContainerNode*)
+void SVGMPathElement::didNotifySubtreeInsertions()
{
buildPendingResource();
}
Modified: trunk/Source/WebCore/svg/SVGMPathElement.h (185422 => 185423)
--- trunk/Source/WebCore/svg/SVGMPathElement.h 2015-06-10 17:42:47 UTC (rev 185422)
+++ trunk/Source/WebCore/svg/SVGMPathElement.h 2015-06-10 18:15:23 UTC (rev 185423)
@@ -53,7 +53,7 @@
virtual void svgAttributeChanged(const QualifiedName&) override;
virtual bool rendererIsNeeded(const RenderStyle&) override { return false; }
- virtual void didNotifySubtreeInsertions(ContainerNode*) override;
+ virtual void didNotifySubtreeInsertions() override;
void notifyParentOfPathChange(ContainerNode*);
Modified: trunk/Source/WebCore/svg/SVGTRefElement.cpp (185422 => 185423)
--- trunk/Source/WebCore/svg/SVGTRefElement.cpp 2015-06-10 17:42:47 UTC (rev 185422)
+++ trunk/Source/WebCore/svg/SVGTRefElement.cpp 2015-06-10 18:15:23 UTC (rev 185423)
@@ -262,7 +262,7 @@
return InsertionDone;
}
-void SVGTRefElement::didNotifySubtreeInsertions(ContainerNode*)
+void SVGTRefElement::didNotifySubtreeInsertions()
{
buildPendingResource();
}
Modified: trunk/Source/WebCore/svg/SVGTRefElement.h (185422 => 185423)
--- trunk/Source/WebCore/svg/SVGTRefElement.h 2015-06-10 17:42:47 UTC (rev 185422)
+++ trunk/Source/WebCore/svg/SVGTRefElement.h 2015-06-10 18:15:23 UTC (rev 185423)
@@ -47,7 +47,7 @@
virtual InsertionNotificationRequest insertedInto(ContainerNode&) override;
virtual void removedFrom(ContainerNode&) override;
- virtual void didNotifySubtreeInsertions(ContainerNode*) override;
+ virtual void didNotifySubtreeInsertions() override;
virtual void clearTarget() override;
Modified: trunk/Source/WebCore/svg/SVGTextPathElement.cpp (185422 => 185423)
--- trunk/Source/WebCore/svg/SVGTextPathElement.cpp 2015-06-10 17:42:47 UTC (rev 185422)
+++ trunk/Source/WebCore/svg/SVGTextPathElement.cpp 2015-06-10 18:15:23 UTC (rev 185423)
@@ -179,7 +179,7 @@
return InsertionShouldCallDidNotifySubtreeInsertions;
}
-void SVGTextPathElement::didNotifySubtreeInsertions(ContainerNode*)
+void SVGTextPathElement::didNotifySubtreeInsertions()
{
buildPendingResource();
}
Modified: trunk/Source/WebCore/svg/SVGTextPathElement.h (185422 => 185423)
--- trunk/Source/WebCore/svg/SVGTextPathElement.h 2015-06-10 17:42:47 UTC (rev 185422)
+++ trunk/Source/WebCore/svg/SVGTextPathElement.h 2015-06-10 18:15:23 UTC (rev 185423)
@@ -112,7 +112,7 @@
static Ref<SVGTextPathElement> create(const QualifiedName&, Document&);
protected:
- virtual void didNotifySubtreeInsertions(ContainerNode*) override;
+ virtual void didNotifySubtreeInsertions() override;
private:
SVGTextPathElement(const QualifiedName&, Document&);
Modified: trunk/Source/WebCore/svg/animation/SVGSMILElement.cpp (185422 => 185423)
--- trunk/Source/WebCore/svg/animation/SVGSMILElement.cpp 2015-06-10 17:42:47 UTC (rev 185422)
+++ trunk/Source/WebCore/svg/animation/SVGSMILElement.cpp 2015-06-10 18:15:23 UTC (rev 185423)
@@ -263,7 +263,7 @@
return InsertionShouldCallDidNotifySubtreeInsertions;
}
-void SVGSMILElement::didNotifySubtreeInsertions(ContainerNode*)
+void SVGSMILElement::didNotifySubtreeInsertions()
{
buildPendingResource();
}
Modified: trunk/Source/WebCore/svg/animation/SVGSMILElement.h (185422 => 185423)
--- trunk/Source/WebCore/svg/animation/SVGSMILElement.h 2015-06-10 17:42:47 UTC (rev 185422)
+++ trunk/Source/WebCore/svg/animation/SVGSMILElement.h 2015-06-10 18:15:23 UTC (rev 185423)
@@ -119,7 +119,7 @@
virtual void setTargetElement(SVGElement*);
virtual void setAttributeName(const QualifiedName&);
- virtual void didNotifySubtreeInsertions(ContainerNode*) override;
+ virtual void didNotifySubtreeInsertions() override;
private:
void buildPendingResource() override;
