Title: [185449] trunk/Tools
- Revision
- 185449
- Author
- [email protected]
- Date
- 2015-06-10 23:55:48 -0700 (Wed, 10 Jun 2015)
Log Message
[EFL] dimmed area for popup does not cover the fullscreen mode.
https://bugs.webkit.org/show_bug.cgi?id=145133
Reviewed by Gyuyoung Kim.
By calling elm_win_resize_object_add(), popup was added as a resize object of elm_win.
as a result, popup can cover the fullscreen area when it enters a fullscreen mode.
* MiniBrowser/efl/main.c:
(on_fullscreen_accept):
(on_fullscreen_deny):
(on_fullscreen_enter):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (185448 => 185449)
--- trunk/Tools/ChangeLog 2015-06-11 05:48:02 UTC (rev 185448)
+++ trunk/Tools/ChangeLog 2015-06-11 06:55:48 UTC (rev 185449)
@@ -1,3 +1,18 @@
+2015-06-10 KwangHyuk Kim <[email protected]>
+
+ [EFL] dimmed area for popup does not cover the fullscreen mode.
+ https://bugs.webkit.org/show_bug.cgi?id=145133
+
+ Reviewed by Gyuyoung Kim.
+
+ By calling elm_win_resize_object_add(), popup was added as a resize object of elm_win.
+ as a result, popup can cover the fullscreen area when it enters a fullscreen mode.
+
+ * MiniBrowser/efl/main.c:
+ (on_fullscreen_accept):
+ (on_fullscreen_deny):
+ (on_fullscreen_enter):
+
2015-06-10 Commit Queue <[email protected]>
Unreviewed, rolling out r185442.
Modified: trunk/Tools/MiniBrowser/efl/main.c (185448 => 185449)
--- trunk/Tools/MiniBrowser/efl/main.c 2015-06-11 05:48:02 UTC (rev 185448)
+++ trunk/Tools/MiniBrowser/efl/main.c 2015-06-11 06:55:48 UTC (rev 185449)
@@ -1638,7 +1638,9 @@
on_fullscreen_accept(void *user_data, Evas_Object *obj, void *event_info)
{
PermissionData *permission_data = (PermissionData *)user_data;
+ Browser_Window *window = window_find_with_ewk_view(permission_data->ewk_view);
+ elm_win_resize_object_del(window->elm_window, permission_data->permission_popup);
evas_object_del(permission_data->permission_popup);
evas_object_focus_set(permission_data->ewk_view, EINA_TRUE);
free(permission_data);
@@ -1648,8 +1650,10 @@
on_fullscreen_deny(void *user_data, Evas_Object *obj, void *event_info)
{
PermissionData *permission_data = (PermissionData *)user_data;
+ Browser_Window *window = window_find_with_ewk_view(permission_data->ewk_view);
ewk_view_fullscreen_exit(permission_data->ewk_view);
+ elm_win_resize_object_del(window->elm_window, permission_data->permission_popup);
evas_object_del(permission_data->permission_popup);
evas_object_focus_set(permission_data->ewk_view, EINA_TRUE);
free(permission_data);
@@ -1685,7 +1689,7 @@
elm_object_text_set(deny_button, "Deny");
elm_object_part_content_set(permission_popup, "button2", deny_button);
evas_object_smart_callback_add(deny_button, "clicked", on_fullscreen_deny, permission_data);
-
+ elm_win_resize_object_add(window->elm_window, permission_popup);
evas_object_show(permission_popup);
return EINA_TRUE;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
