Title: [185535] trunk/Websites/perf.webkit.org
- Revision
- 185535
- Author
- [email protected]
- Date
- 2015-06-13 01:16:24 -0700 (Sat, 13 Jun 2015)
Log Message
Perf dashboard's v2 UI shouldn't hide auto-detected outliers
https://bugs.webkit.org/show_bug.cgi?id=145940
Reviewed by Darin Adler.
Don't fallback to the default strategies for moving averages and envelope when one is not specified.
Also deleted the code to mark points outside the envelop as outliers.
* public/v2/app.js:
Modified Paths
Diff
Modified: trunk/Websites/perf.webkit.org/ChangeLog (185534 => 185535)
--- trunk/Websites/perf.webkit.org/ChangeLog 2015-06-13 06:31:31 UTC (rev 185534)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2015-06-13 08:16:24 UTC (rev 185535)
@@ -1,3 +1,15 @@
+2015-06-13 Ryosuke Niwa <[email protected]>
+
+ Perf dashboard's v2 UI shouldn't hide auto-detected outliers
+ https://bugs.webkit.org/show_bug.cgi?id=145940
+
+ Reviewed by Darin Adler.
+
+ Don't fallback to the default strategies for moving averages and envelope when one is not specified.
+ Also deleted the code to mark points outside the envelop as outliers.
+
+ * public/v2/app.js:
+
2015-06-12 Ryosuke Niwa <[email protected]>
Unreviewed build fix for merging platforms.
Modified: trunk/Websites/perf.webkit.org/public/v2/app.js (185534 => 185535)
--- trunk/Websites/perf.webkit.org/public/v2/app.js 2015-06-13 06:31:31 UTC (rev 185534)
+++ trunk/Websites/perf.webkit.org/public/v2/app.js 2015-06-13 08:16:24 UTC (rev 185535)
@@ -586,8 +586,10 @@
var rawValues = chartData.current.rawValues();
var movingAverageIsSetByUser = movingAverageStrategy && movingAverageStrategy.execute;
- var movingAverageValues = Statistics.executeStrategy(
- movingAverageIsSetByUser ? movingAverageStrategy : Statistics.MovingAverageStrategies[0], rawValues);
+ if (!movingAverageIsSetByUser)
+ return null;
+
+ var movingAverageValues = Statistics.executeStrategy(movingAverageStrategy, rawValues);
if (!movingAverageValues)
return null;
@@ -595,34 +597,24 @@
if (movingAverageStrategy && movingAverageStrategy.isSegmentation && testRangeSelectionStrategy && testRangeSelectionStrategy.execute)
testRangeCandidates = Statistics.executeStrategy(testRangeSelectionStrategy, rawValues, [movingAverageValues]);
- var envelopeIsSetByUser = envelopingStrategy && envelopingStrategy.execute;
- var envelopeDelta = Statistics.executeStrategy(envelopeIsSetByUser ? envelopingStrategy : Statistics.EnvelopingStrategies[0],
- rawValues, [movingAverageValues]);
-
- for (var i = 0; i < currentTimeSeriesData.length; i++) {
- var currentValue = currentTimeSeriesData[i].value;
- var movingAverageValue = movingAverageValues[i];
- if (currentValue < movingAverageValue - envelopeDelta || movingAverageValue + envelopeDelta < currentValue)
- currentTimeSeriesData[i].isOutlier = true;
- }
- if (!envelopeIsSetByUser)
- envelopeDelta = null;
-
- var anomalies = {};
- if (anomalyDetectionStrategies.length) {
- var isAnomalyArray = new Array(currentTimeSeriesData.length);
- for (var strategy of anomalyDetectionStrategies) {
- var anomalyLengths = Statistics.executeStrategy(strategy, rawValues, [movingAverageValues, envelopeDelta]);
- for (var i = 0; i < currentTimeSeriesData.length; i++)
- isAnomalyArray[i] = isAnomalyArray[i] || anomalyLengths[i];
+ if (envelopingStrategy && envelopingStrategy.execute) {
+ var envelopeDelta = Statistics.executeStrategy(envelopingStrategy, rawValues, [movingAverageValues]);
+ var anomalies = {};
+ if (anomalyDetectionStrategies.length) {
+ var isAnomalyArray = new Array(currentTimeSeriesData.length);
+ for (var strategy of anomalyDetectionStrategies) {
+ var anomalyLengths = Statistics.executeStrategy(strategy, rawValues, [movingAverageValues, envelopeDelta]);
+ for (var i = 0; i < currentTimeSeriesData.length; i++)
+ isAnomalyArray[i] = isAnomalyArray[i] || anomalyLengths[i];
+ }
+ for (var i = 0; i < isAnomalyArray.length; i++) {
+ if (!isAnomalyArray[i])
+ continue;
+ anomalies[currentTimeSeriesData[i].measurement.id()] = true;
+ while (isAnomalyArray[i] && i < isAnomalyArray.length)
+ ++i;
+ }
}
- for (var i = 0; i < isAnomalyArray.length; i++) {
- if (!isAnomalyArray[i])
- continue;
- anomalies[currentTimeSeriesData[i].measurement.id()] = true;
- while (isAnomalyArray[i] && i < isAnomalyArray.length)
- ++i;
- }
}
var movingAverageTimeSeries = null;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
