Title: [185562] trunk/Source/WebInspectorUI
- Revision
- 185562
- Author
- [email protected]
- Date
- 2015-06-15 12:16:51 -0700 (Mon, 15 Jun 2015)
Log Message
Web Inspector: Improve some cases of "Object?" Type Annotations
https://bugs.webkit.org/show_bug.cgi?id=145954
Patch by Joseph Pecoraro <[email protected]> on 2015-06-15
Reviewed by Timothy Hatcher.
* UserInterface/Views/TypeTokenView.js:
(WebInspector.TypeTokenView.prototype._displayTypeName):
The TypeSet inclusions cover all types, so we can use the leastCommonAncestor
name as long as the type set is just object or object and null/undefined.
If the typeset includes other primitives then it will gracefully go down
below to become something like Object or (many).
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (185561 => 185562)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-06-15 19:07:33 UTC (rev 185561)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-06-15 19:16:51 UTC (rev 185562)
@@ -1,3 +1,17 @@
+2015-06-15 Joseph Pecoraro <[email protected]>
+
+ Web Inspector: Improve some cases of "Object?" Type Annotations
+ https://bugs.webkit.org/show_bug.cgi?id=145954
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Views/TypeTokenView.js:
+ (WebInspector.TypeTokenView.prototype._displayTypeName):
+ The TypeSet inclusions cover all types, so we can use the leastCommonAncestor
+ name as long as the type set is just object or object and null/undefined.
+ If the typeset includes other primitives then it will gracefully go down
+ below to become something like Object or (many).
+
2015-06-14 Andres Gomez <[email protected]>
[GTK] Web Inspector: Update icon so Rendering Frames timeline distinguish between layout and painting
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TypeTokenView.js (185561 => 185562)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TypeTokenView.js 2015-06-15 19:07:33 UTC (rev 185561)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TypeTokenView.js 2015-06-15 19:16:51 UTC (rev 185562)
@@ -132,7 +132,7 @@
var typeSet = this._typeDescription.typeSet;
- if (this._typeDescription.leastCommonAncestor && !this._typeDescription.typeSet.primitiveTypeNames.length) {
+ if (this._typeDescription.leastCommonAncestor) {
if (typeSet.isContainedIn(WebInspector.TypeSet.TypeBit.Object))
return this._typeDescription.leastCommonAncestor;
if (typeSet.isContainedIn(WebInspector.TypeSet.TypeBit.Object | WebInspector.TypeSet.NullOrUndefinedTypeBits))
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
