Title: [185596] trunk/Source/_javascript_Core
- Revision
- 185596
- Author
- saambara...@gmail.com
- Date
- 2015-06-16 11:34:24 -0700 (Tue, 16 Jun 2015)
Log Message
LLInt's code path for get_from_scope with case GlobalVarWithVarInjectionChecks has dead code
https://bugs.webkit.org/show_bug.cgi?id=144268
Reviewed by Darin Adler.
The call to loadVariable(.) both for 32bit and 64bit is unnecessary.
It grabs a value that is immediately overwritten by a call to getGlobalVar().
* llint/LowLevelInterpreter32_64.asm:
* llint/LowLevelInterpreter64.asm:
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (185595 => 185596)
--- trunk/Source/_javascript_Core/ChangeLog 2015-06-16 17:58:19 UTC (rev 185595)
+++ trunk/Source/_javascript_Core/ChangeLog 2015-06-16 18:34:24 UTC (rev 185596)
@@ -1,3 +1,16 @@
+2015-06-16 Saam Barati <saambara...@gmail.com>
+
+ LLInt's code path for get_from_scope with case GlobalVarWithVarInjectionChecks has dead code
+ https://bugs.webkit.org/show_bug.cgi?id=144268
+
+ Reviewed by Darin Adler.
+
+ The call to loadVariable(.) both for 32bit and 64bit is unnecessary.
+ It grabs a value that is immediately overwritten by a call to getGlobalVar().
+
+ * llint/LowLevelInterpreter32_64.asm:
+ * llint/LowLevelInterpreter64.asm:
+
2015-06-14 Yusuke Suzuki <utatane....@gmail.com>
[ES6] Introduce %IteratorPrototype% and drop all XXXIteratorConstructor
Modified: trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm (185595 => 185596)
--- trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm 2015-06-16 17:58:19 UTC (rev 185595)
+++ trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm 2015-06-16 18:34:24 UTC (rev 185596)
@@ -2197,7 +2197,6 @@
.gGlobalVarWithVarInjectionChecks:
bineq t0, GlobalVarWithVarInjectionChecks, .gClosureVarWithVarInjectionChecks
varInjectionCheck(.gDynamic)
- loadVariable(2, t2, t1, t0)
getGlobalVar()
dispatch(8)
Modified: trunk/Source/_javascript_Core/llint/LowLevelInterpreter64.asm (185595 => 185596)
--- trunk/Source/_javascript_Core/llint/LowLevelInterpreter64.asm 2015-06-16 17:58:19 UTC (rev 185595)
+++ trunk/Source/_javascript_Core/llint/LowLevelInterpreter64.asm 2015-06-16 18:34:24 UTC (rev 185596)
@@ -2063,7 +2063,6 @@
.gGlobalVarWithVarInjectionChecks:
bineq t0, GlobalVarWithVarInjectionChecks, .gClosureVarWithVarInjectionChecks
varInjectionCheck(.gDynamic)
- loadVariable(2, t0)
getGlobalVar()
dispatch(8)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
