Title: [185651] trunk/Source/WebKit2
- Revision
- 185651
- Author
- [email protected]
- Date
- 2015-06-17 08:32:38 -0700 (Wed, 17 Jun 2015)
Log Message
[GTK] WEBKIT_CACHE_MODEL_DOCUMENT_VIEWER doesn't disable memory cache when set before the web process is launched
https://bugs.webkit.org/show_bug.cgi?id=146053
Reviewed by Martin Robinson.
The cache is disabled in WebProcess::platformSetCacheModel() when
the cache model is CacheModelDocumentViewer, but it's enabled
again by WebProcess::setMemoryCacheDisabled() when
memoryCacheDisabled creation parameter is processed. We need to
make sure the cache model and memoryCacheDisabled parameters are consistent.
* UIProcess/gtk/WebProcessPoolGtk.cpp:
(WebKit::WebProcessPool::platformInitializeWebProcess): Initialize
memoryCacheDisabled parameter to true if memory cache was
explicitly disabled or cache model is CacheModelDocumentViewer.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (185650 => 185651)
--- trunk/Source/WebKit2/ChangeLog 2015-06-17 15:21:19 UTC (rev 185650)
+++ trunk/Source/WebKit2/ChangeLog 2015-06-17 15:32:38 UTC (rev 185651)
@@ -1,3 +1,21 @@
+2015-06-17 Carlos Garcia Campos <[email protected]>
+
+ [GTK] WEBKIT_CACHE_MODEL_DOCUMENT_VIEWER doesn't disable memory cache when set before the web process is launched
+ https://bugs.webkit.org/show_bug.cgi?id=146053
+
+ Reviewed by Martin Robinson.
+
+ The cache is disabled in WebProcess::platformSetCacheModel() when
+ the cache model is CacheModelDocumentViewer, but it's enabled
+ again by WebProcess::setMemoryCacheDisabled() when
+ memoryCacheDisabled creation parameter is processed. We need to
+ make sure the cache model and memoryCacheDisabled parameters are consistent.
+
+ * UIProcess/gtk/WebProcessPoolGtk.cpp:
+ (WebKit::WebProcessPool::platformInitializeWebProcess): Initialize
+ memoryCacheDisabled parameter to true if memory cache was
+ explicitly disabled or cache model is CacheModelDocumentViewer.
+
2015-06-17 Zan Dobersek <[email protected]>
[WK2] valueForKey() shouldn't copy the defaults map
Modified: trunk/Source/WebKit2/UIProcess/gtk/WebProcessPoolGtk.cpp (185650 => 185651)
--- trunk/Source/WebKit2/UIProcess/gtk/WebProcessPoolGtk.cpp 2015-06-17 15:21:19 UTC (rev 185650)
+++ trunk/Source/WebKit2/UIProcess/gtk/WebProcessPoolGtk.cpp 2015-06-17 15:32:38 UTC (rev 185651)
@@ -108,6 +108,8 @@
parameters.ignoreTLSErrors = m_ignoreTLSErrors;
parameters.diskCacheDirectory = m_configuration->diskCacheDirectory();
}
+
+ parameters.memoryCacheDisabled = m_memoryCacheDisabled || m_cacheModel == CacheModelDocumentViewer;
}
void WebProcessPool::platformInvalidateContext()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
