Title: [185677] trunk/Source/WebKit2
- Revision
- 185677
- Author
- [email protected]
- Date
- 2015-06-17 16:38:39 -0700 (Wed, 17 Jun 2015)
Log Message
Remove willSendEventToPlugin() from PluginController.h.
https://bugs.webkit.org/show_bug.cgi?id=146054
Patch by Sungmann Cho <[email protected]> on 2015-06-17
Reviewed by Darin Adler.
PluginController::willSendEventToPlugin() was introduced by http://webkit.org/b/59124.
This method had been used only for WebKit2 on Windows, and no one uses it now.
So we can remove it.
No new tests, no behavior change.
* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::willSendEventToPlugin): Deleted.
* PluginProcess/PluginControllerProxy.h:
* WebProcess/Plugins/PluginController.h:
* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::willSendEventToPlugin): Deleted.
* WebProcess/Plugins/PluginView.h:
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (185676 => 185677)
--- trunk/Source/WebKit2/ChangeLog 2015-06-17 23:23:51 UTC (rev 185676)
+++ trunk/Source/WebKit2/ChangeLog 2015-06-17 23:38:39 UTC (rev 185677)
@@ -1,3 +1,24 @@
+2015-06-17 Sungmann Cho <[email protected]>
+
+ Remove willSendEventToPlugin() from PluginController.h.
+ https://bugs.webkit.org/show_bug.cgi?id=146054
+
+ Reviewed by Darin Adler.
+
+ PluginController::willSendEventToPlugin() was introduced by http://webkit.org/b/59124.
+ This method had been used only for WebKit2 on Windows, and no one uses it now.
+ So we can remove it.
+
+ No new tests, no behavior change.
+
+ * PluginProcess/PluginControllerProxy.cpp:
+ (WebKit::PluginControllerProxy::willSendEventToPlugin): Deleted.
+ * PluginProcess/PluginControllerProxy.h:
+ * WebProcess/Plugins/PluginController.h:
+ * WebProcess/Plugins/PluginView.cpp:
+ (WebKit::PluginView::willSendEventToPlugin): Deleted.
+ * WebProcess/Plugins/PluginView.h:
+
2015-06-17 Tim Horton <[email protected]>
Repro crash when swiping back from a NY Times article @ WebPageProxy::navigationGestureDidEnd
Modified: trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp (185676 => 185677)
--- trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp 2015-06-17 23:23:51 UTC (rev 185676)
+++ trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp 2015-06-17 23:38:39 UTC (rev 185677)
@@ -325,12 +325,6 @@
ASSERT_NOT_REACHED();
}
-void PluginControllerProxy::willSendEventToPlugin()
-{
- // This is only used when running plugins in the web process.
- ASSERT_NOT_REACHED();
-}
-
void PluginControllerProxy::didInitializePlugin()
{
// This should only be called on the plugin in the web process.
Modified: trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.h (185676 => 185677)
--- trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.h 2015-06-17 23:23:51 UTC (rev 185676)
+++ trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.h 2015-06-17 23:38:39 UTC (rev 185677)
@@ -95,7 +95,6 @@
virtual void setStatusbarText(const String&) override;
virtual bool isAcceleratedCompositingEnabled() override;
virtual void pluginProcessCrashed() override;
- virtual void willSendEventToPlugin() override;
virtual void didInitializePlugin() override;
virtual void didFailToInitializePlugin() override;
Modified: trunk/Source/WebKit2/WebProcess/Plugins/PluginController.h (185676 => 185677)
--- trunk/Source/WebKit2/WebProcess/Plugins/PluginController.h 2015-06-17 23:23:51 UTC (rev 185676)
+++ trunk/Source/WebKit2/WebProcess/Plugins/PluginController.h 2015-06-17 23:38:39 UTC (rev 185677)
@@ -95,10 +95,7 @@
// Tells the controller that the plug-in process has crashed.
virtual void pluginProcessCrashed() = 0;
-
- // Tells the controller that we're about to dispatch an event to the plug-in.
- virtual void willSendEventToPlugin() = 0;
-
+
#if PLATFORM(COCOA)
// Tells the controller that the plug-in focus or window focus did change.
virtual void pluginFocusOrWindowFocusChanged(bool) = 0;
Modified: trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp (185676 => 185677)
--- trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp 2015-06-17 23:23:51 UTC (rev 185676)
+++ trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp 2015-06-17 23:38:39 UTC (rev 185677)
@@ -1515,14 +1515,6 @@
Widget::invalidate();
}
-void PluginView::willSendEventToPlugin()
-{
- // If we're sending an event to a plug-in, we can't control how long the plug-in
- // takes to process it (e.g. it may display a context menu), so we tell the UI process
- // to stop the responsiveness timer in this case.
- m_webPage->send(Messages::WebPageProxy::StopResponsivenessTimer());
-}
-
#if PLATFORM(COCOA)
void PluginView::pluginFocusOrWindowFocusChanged(bool pluginHasFocusAndWindowHasFocus)
{
Modified: trunk/Source/WebKit2/WebProcess/Plugins/PluginView.h (185676 => 185677)
--- trunk/Source/WebKit2/WebProcess/Plugins/PluginView.h 2015-06-17 23:23:51 UTC (rev 185676)
+++ trunk/Source/WebKit2/WebProcess/Plugins/PluginView.h 2015-06-17 23:38:39 UTC (rev 185677)
@@ -207,7 +207,6 @@
virtual void setStatusbarText(const String&) override;
virtual bool isAcceleratedCompositingEnabled() override;
virtual void pluginProcessCrashed() override;
- virtual void willSendEventToPlugin() override;
#if PLATFORM(COCOA)
virtual void pluginFocusOrWindowFocusChanged(bool pluginHasFocusAndWindowHasFocus) override;
virtual void setComplexTextInputState(PluginComplexTextInputState) override;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
