Title: [185696] trunk/Source/WebKit2
Revision
185696
Author
[email protected]
Date
2015-06-18 01:57:09 -0700 (Thu, 18 Jun 2015)

Log Message

[EFL] test_ewk2_context has been failed since r185529
https://bugs.webkit.org/show_bug.cgi?id=146046

Reviewed by Csaba Osztrogonác.

ewk_context_network_process_model test has been failed since r185529.
This patch modifies the test which is similar to ewk_context_network_process_model
based on multiple process model to fix the failure. Besides ewk_context_network_process_model
seems to be fixed indirectly. So we enable it again.

* UIProcess/API/efl/tests/test_ewk2_context.cpp:
(TEST_F):

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (185695 => 185696)


--- trunk/Source/WebKit2/ChangeLog	2015-06-18 08:35:43 UTC (rev 185695)
+++ trunk/Source/WebKit2/ChangeLog	2015-06-18 08:57:09 UTC (rev 185696)
@@ -1,3 +1,18 @@
+2015-06-18  Gyuyoung Kim  <[email protected]>
+
+        [EFL] test_ewk2_context has been failed since r185529
+        https://bugs.webkit.org/show_bug.cgi?id=146046
+
+        Reviewed by Csaba Osztrogonác.
+
+        ewk_context_network_process_model test has been failed since r185529.
+        This patch modifies the test which is similar to ewk_context_network_process_model
+        based on multiple process model to fix the failure. Besides ewk_context_network_process_model
+        seems to be fixed indirectly. So we enable it again.
+
+        * UIProcess/API/efl/tests/test_ewk2_context.cpp:
+        (TEST_F):
+
 2015-06-17  Yongjun Zhang  <[email protected]>
 
         Also turn off long press on link preview.

Modified: trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_context.cpp (185695 => 185696)


--- trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_context.cpp	2015-06-18 08:35:43 UTC (rev 185695)
+++ trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_context.cpp	2015-06-18 08:57:09 UTC (rev 185696)
@@ -210,12 +210,13 @@
 
     ASSERT_EQ(webView1WebProcessID, webView2WebProcessID);
 
-    ASSERT_TRUE(toImpl(EWKViewGetWKView(webView1))->page()->process().processPool().networkProcess() == nullptr);
-    ASSERT_TRUE(toImpl(EWKViewGetWKView(webView2))->page()->process().processPool().networkProcess() == nullptr);
+    PlatformProcessIdentifier webView1NetworkProcessID = toImpl(EWKViewGetWKView(webView1))->page()->process().processPool().networkProcess()->processIdentifier();
+    PlatformProcessIdentifier webView2NetworkProcessID = toImpl(EWKViewGetWKView(webView2))->page()->process().processPool().networkProcess()->processIdentifier();
+
+    ASSERT_EQ(webView1NetworkProcessID, webView2NetworkProcessID);
 }
 
-
-TEST_F(EWK2ContextTestMultipleProcesses, DISABLED_ewk_context_network_process_model)
+TEST_F(EWK2ContextTestMultipleProcesses, ewk_context_network_process_model)
 {
     Ewk_Context* context = ewk_view_context_get(webView());
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to