Title: [185698] trunk/Tools
Revision
185698
Author
[email protected]
Date
2015-06-18 02:22:48 -0700 (Thu, 18 Jun 2015)

Log Message

Remove redundant Chromium bug keyword
https://bugs.webkit.org/show_bug.cgi?id=146097

Reviewed by Csaba Osztrogonác.

* Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectationParser._parse_modifiers): Remove BUGCR for TestExpectations.
(TestExpectationLine._format_line): Deleted.

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (185697 => 185698)


--- trunk/Tools/ChangeLog	2015-06-18 08:58:18 UTC (rev 185697)
+++ trunk/Tools/ChangeLog	2015-06-18 09:22:48 UTC (rev 185698)
@@ -1,3 +1,14 @@
+2015-06-18  Gyuyoung Kim  <[email protected]>
+
+        Remove redundant Chromium bug keyword
+        https://bugs.webkit.org/show_bug.cgi?id=146097
+
+        Reviewed by Csaba Osztrogonác.
+
+        * Scripts/webkitpy/layout_tests/models/test_expectations.py:
+        (TestExpectationParser._parse_modifiers): Remove BUGCR for TestExpectations.
+        (TestExpectationLine._format_line): Deleted.
+
 2015-06-17  Daniel Bates  <[email protected]>
 
         Client may receive began editing callback for already focused text field

Modified: trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py (185697 => 185698)


--- trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py	2015-06-18 08:58:18 UTC (rev 185697)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py	2015-06-18 09:22:48 UTC (rev 185698)
@@ -148,7 +148,7 @@
             elif modifier.startswith(self.BUG_MODIFIER_PREFIX):
                 has_bugid = True
                 if re.match(self.BUG_MODIFIER_REGEX, modifier):
-                    expectation_line.warnings.append('BUG\d+ is not allowed, must be one of BUGCR\d+, BUGWK\d+, BUGV8_\d+, or a non-numeric bug identifier.')
+                    expectation_line.warnings.append('BUG\d+ is not allowed, must be one of BUGWK\d+, or a non-numeric bug identifier.')
                 else:
                     expectation_line.parsed_bug_modifiers.append(modifier)
             else:
@@ -447,8 +447,6 @@
             modifier = modifier.upper()
             if modifier.startswith('BUGWK'):
                 bugs.append('webkit.org/b/' + modifier.replace('BUGWK', ''))
-            elif modifier.startswith('BUGCR'):
-                bugs.append('crbug.com/' + modifier.replace('BUGCR', ''))
             elif modifier.startswith('BUG'):
                 # FIXME: we should preserve case once we can drop the old syntax.
                 bugs.append('Bug(' + modifier[3:].lower() + ')')
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to