Title: [185703] trunk/Source/WebInspectorUI
- Revision
- 185703
- Author
- [email protected]
- Date
- 2015-06-18 10:13:21 -0700 (Thu, 18 Jun 2015)
Log Message
Unreviewed, rolling out r185671.
https://bugs.webkit.org/show_bug.cgi?id=146114
Caused frequent flaky failures on profiler tests (Requested by
ap on #webkit).
Reverted changeset:
"Web Inspector: Improve a few more node preview types"
https://bugs.webkit.org/show_bug.cgi?id=146048
http://trac.webkit.org/changeset/185671
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (185702 => 185703)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-06-18 17:11:02 UTC (rev 185702)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-06-18 17:13:21 UTC (rev 185703)
@@ -1,3 +1,17 @@
+2015-06-18 Commit Queue <[email protected]>
+
+ Unreviewed, rolling out r185671.
+ https://bugs.webkit.org/show_bug.cgi?id=146114
+
+ Caused frequent flaky failures on profiler tests (Requested by
+ ap on #webkit).
+
+ Reverted changeset:
+
+ "Web Inspector: Improve a few more node preview types"
+ https://bugs.webkit.org/show_bug.cgi?id=146048
+ http://trac.webkit.org/changeset/185671
+
2015-06-17 Joseph Pecoraro <[email protected]>
Web Inspector: Improve a few more node preview types
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/FormattedValue.js (185702 => 185703)
--- trunk/Source/WebInspectorUI/UserInterface/Views/FormattedValue.js 2015-06-18 17:11:02 UTC (rev 185702)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/FormattedValue.js 2015-06-18 17:13:21 UTC (rev 185703)
@@ -69,34 +69,15 @@
WebInspector.FormattedValue.createElementForNodePreview = function(preview)
{
- var value = preview.value;
var span = document.createElement("span");
span.className = "formatted-node-preview syntax-highlighted";
- // Comment node preview.
- if (value.startsWith("<!--")) {
- var comment = span.appendChild(document.createElement("span"));
- comment.className = "html-comment";
- comment.textContent = value;
- return span;
- }
-
- // Doctype node preview.
- if (value.startsWith("<!DOCTYPE")) {
- var doctype = span.appendChild(document.createElement("span"));
- doctype.className = "html-doctype";
- doctype.textContent = value;
- return span;
- }
-
- // Element node previews have a very strict format, with at most a single attribute.
+ // A node preview has a very strict format, with at most a single attribute.
// We can style it up like a DOMNode without interactivity.
- var matches = value.match(/^<(\S+?)(?: (\S+?)="(.*?)")?>$/);
-
- // Remaining node types are often #text, #document, etc, with attribute nodes potentially being any string.
+ var matches = preview.value.match(/^<(\S+?)(?: (\S+?)="(.*?)")?>$/);
if (!matches) {
- console.assert(!value.startsWith("<"), "Unexpected node preview format: " + value);
- span.textContent = value;
+ console.error("Node preview did not match format.", preview.value)
+ span.textContent = preview.value;
return span;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
