Title: [185800] trunk/Source/WebInspectorUI
- Revision
- 185800
- Author
- [email protected]
- Date
- 2015-06-20 15:47:39 -0700 (Sat, 20 Jun 2015)
Log Message
Web Inspector: Unable to select parent element in the DOM tree path bar
https://bugs.webkit.org/show_bug.cgi?id=145810
Reviewed by Timothy Hatcher.
* UserInterface/Views/DOMTreeContentView.js:
(WebInspector.DOMTreeContentView.prototype.get selectionPathComponents):
* UserInterface/Views/HierarchicalPathComponent.js:
(WebInspector.HierarchicalPathComponent.prototype.get selectedPathComponent):
(WebInspector.HierarchicalPathComponent.prototype._selectElementMouseUp):
(WebInspector.HierarchicalPathComponent.prototype._selectElementSelectionChanged):
(WebInspector.HierarchicalPathComponent):
(WebInspector.HierarchicalPathComponent.prototype._selectElementMouseDown): Deleted.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (185799 => 185800)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-06-20 20:50:35 UTC (rev 185799)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-06-20 22:47:39 UTC (rev 185800)
@@ -1,3 +1,19 @@
+2015-06-20 Nikita Vasilyev <[email protected]>
+
+ Web Inspector: Unable to select parent element in the DOM tree path bar
+ https://bugs.webkit.org/show_bug.cgi?id=145810
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Views/DOMTreeContentView.js:
+ (WebInspector.DOMTreeContentView.prototype.get selectionPathComponents):
+ * UserInterface/Views/HierarchicalPathComponent.js:
+ (WebInspector.HierarchicalPathComponent.prototype.get selectedPathComponent):
+ (WebInspector.HierarchicalPathComponent.prototype._selectElementMouseUp):
+ (WebInspector.HierarchicalPathComponent.prototype._selectElementSelectionChanged):
+ (WebInspector.HierarchicalPathComponent):
+ (WebInspector.HierarchicalPathComponent.prototype._selectElementMouseDown): Deleted.
+
2015-06-19 Joseph Pecoraro <[email protected]>
Web Inspector: Duplication of style attribute in rules panel for shadow content
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js (185799 => 185800)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js 2015-06-20 20:50:35 UTC (rev 185799)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js 2015-06-20 22:47:39 UTC (rev 185800)
@@ -123,7 +123,7 @@
}
var pathComponent = new WebInspector.DOMTreeElementPathComponent(treeElement, treeElement.representedObject);
- pathComponent.addEventListener(WebInspector.HierarchicalPathComponent.Event.SiblingWasSelected, this._pathComponentSelected, this);
+ pathComponent.addEventListener(WebInspector.HierarchicalPathComponent.Event.Clicked, this._pathComponentSelected, this);
pathComponents.unshift(pathComponent);
treeElement = treeElement.parent;
}
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/HierarchicalPathComponent.js (185799 => 185800)
--- trunk/Source/WebInspectorUI/UserInterface/Views/HierarchicalPathComponent.js 2015-06-20 20:50:35 UTC (rev 185799)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/HierarchicalPathComponent.js 2015-06-20 22:47:39 UTC (rev 185800)
@@ -84,6 +84,12 @@
// Public
+ get selectedPathComponent()
+ {
+ var selectElement = this._selectElement[this._selectElement.selectedIndex];
+ return selectElement && selectElement._pathComponent || null;
+ }
+
get element()
{
return this._element;
@@ -305,12 +311,12 @@
_selectElementMouseUp(event)
{
- this.dispatchEventToListeners(WebInspector.HierarchicalPathComponent.Event.Clicked);
+ this.dispatchEventToListeners(WebInspector.HierarchicalPathComponent.Event.Clicked, {pathComponent: this.selectedPathComponent});
}
_selectElementSelectionChanged(event)
{
- this.dispatchEventToListeners(WebInspector.HierarchicalPathComponent.Event.SiblingWasSelected, {pathComponent: this._selectElement[this._selectElement.selectedIndex]._pathComponent});
+ this.dispatchEventToListeners(WebInspector.HierarchicalPathComponent.Event.SiblingWasSelected, {pathComponent: this.selectedPathComponent});
}
};
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
