Title: [185809] trunk/LayoutTests
- Revision
- 185809
- Author
- [email protected]
- Date
- 2015-06-21 08:57:04 -0700 (Sun, 21 Jun 2015)
Log Message
fast/css-grid-layout/flex-content-sized-columns-resize.html is flaky
The Flakiness Dashboard says this test is flaky on Apple and EFL
WebKit2 platforms:
<http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fcss-grid-layout%2Fflex-content-sized-columns-resize.html>
It currently doesn't wait for window.resize() to complete, which
is likely the source of flakiness.
* fast/css-grid-layout/flex-content-sized-columns-resize.html:
Switch to using notifyDone() inside a window.onresize function,
and make the test work in a web browser without TestRunner.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (185808 => 185809)
--- trunk/LayoutTests/ChangeLog 2015-06-21 13:19:19 UTC (rev 185808)
+++ trunk/LayoutTests/ChangeLog 2015-06-21 15:57:04 UTC (rev 185809)
@@ -1,3 +1,19 @@
+2015-06-21 David Kilzer <[email protected]>
+
+ fast/css-grid-layout/flex-content-sized-columns-resize.html is flaky
+
+ The Flakiness Dashboard says this test is flaky on Apple and EFL
+ WebKit2 platforms:
+
+ <http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fcss-grid-layout%2Fflex-content-sized-columns-resize.html>
+
+ It currently doesn't wait for window.resize() to complete, which
+ is likely the source of flakiness.
+
+ * fast/css-grid-layout/flex-content-sized-columns-resize.html:
+ Switch to using notifyDone() inside a window.onresize function,
+ and make the test work in a web browser without TestRunner.
+
2015-06-20 David Kilzer <[email protected]>
REGRESSION (r185779): fast/canvas/{canvas-toDataURL-crash,pattern-too-large-to-create}.html are broken
Modified: trunk/LayoutTests/fast/css-grid-layout/flex-content-sized-columns-resize.html (185808 => 185809)
--- trunk/LayoutTests/fast/css-grid-layout/flex-content-sized-columns-resize.html 2015-06-21 13:19:19 UTC (rev 185808)
+++ trunk/LayoutTests/fast/css-grid-layout/flex-content-sized-columns-resize.html 2015-06-21 15:57:04 UTC (rev 185809)
@@ -12,14 +12,21 @@
}
</style>
<script>
-function runTest() {
+window._onload_ = function () {
if (window.testRunner) {
- window.resizeTo(600, 600);
+ testRunner.waitUntilDone();
}
+ window.resizeTo(600, 600);
}
+
+window._onresize_ = function () {
+ if (window.testRunner) {
+ testRunner.notifyDone();
+ }
+}
</script>
</head>
-<body _onLoad_="runTest();">
+<body>
<h1>Description</h1>
<p>Grid flex and content sized columns width should be updated properly when you resize the window (you should not see the grid background in grey color).</p>
<h1>Grid 2 flex columns</h1>
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
