Title: [185891] trunk/Source/WebInspectorUI
- Revision
- 185891
- Author
- [email protected]
- Date
- 2015-06-23 17:27:29 -0700 (Tue, 23 Jun 2015)
Log Message
Web Inspector: TextEditor scroll position not correctly restored when switching tabs
https://bugs.webkit.org/show_bug.cgi?id=146254
Patch by Joseph Pecoraro <[email protected]> on 2015-06-23
Reviewed by Timothy Hatcher.
* UserInterface/Views/TextEditor.js:
(WebInspector.TextEditor.prototype.updateLayout):
Workaround a larger issue with ContentView restoration so that
TextEditors restore their scroll position as expected.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (185890 => 185891)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-06-24 00:21:04 UTC (rev 185890)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-06-24 00:27:29 UTC (rev 185891)
@@ -1,5 +1,17 @@
2015-06-23 Joseph Pecoraro <[email protected]>
+ Web Inspector: TextEditor scroll position not correctly restored when switching tabs
+ https://bugs.webkit.org/show_bug.cgi?id=146254
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Views/TextEditor.js:
+ (WebInspector.TextEditor.prototype.updateLayout):
+ Workaround a larger issue with ContentView restoration so that
+ TextEditors restore their scroll position as expected.
+
+2015-06-23 Joseph Pecoraro <[email protected]>
+
Web Inspector: Some brief previews are incorrectly treated as lossless
https://bugs.webkit.org/show_bug.cgi?id=146247
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TextEditor.js (185890 => 185891)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TextEditor.js 2015-06-24 00:21:04 UTC (rev 185890)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TextEditor.js 2015-06-24 00:27:29 UTC (rev 185891)
@@ -506,7 +506,11 @@
updateLayout(force)
{
- this._codeMirror.refresh();
+ // FIXME: <https://webkit.org/b/146256> Web Inspector: Nested ContentBrowsers / ContentViewContainers cause too many ContentView updates
+ // Ideally we would not get an updateLayout call if we are not visible. We should restructure ContentView
+ // show/hide restoration to reduce duplicated work and solve this in the process.
+ if (this._visible)
+ this._codeMirror.refresh();
}
shown()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
