Title: [186063] trunk/Source/WebKit2
- Revision
- 186063
- Author
- [email protected]
- Date
- 2015-06-28 22:05:37 -0700 (Sun, 28 Jun 2015)
Log Message
AX: iOS: Crash at accessibilityObjectForMainFramePlugin()
https://bugs.webkit.org/show_bug.cgi?id=146399
Reviewed by Darin Adler.
Could not reproduce issue, but the invalid address seems to indicate this is a nullptr access is happening when we try to get the plugin of the m_page variable when
it has not been initialized.
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::accessibilityObjectForMainFramePlugin):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (186062 => 186063)
--- trunk/Source/WebKit2/ChangeLog 2015-06-29 04:47:46 UTC (rev 186062)
+++ trunk/Source/WebKit2/ChangeLog 2015-06-29 05:05:37 UTC (rev 186063)
@@ -1,3 +1,16 @@
+2015-06-28 Chris Fleizach <[email protected]>
+
+ AX: iOS: Crash at accessibilityObjectForMainFramePlugin()
+ https://bugs.webkit.org/show_bug.cgi?id=146399
+
+ Reviewed by Darin Adler.
+
+ Could not reproduce issue, but the invalid address seems to indicate this is a nullptr access is happening when we try to get the plugin of the m_page variable when
+ it has not been initialized.
+
+ * WebProcess/WebPage/ios/WebPageIOS.mm:
+ (WebKit::WebPage::accessibilityObjectForMainFramePlugin):
+
2015-06-28 Gyuyoung Kim <[email protected]>
Use Ref/RefPtr instead of PassRefPtr in WebKit2
Modified: trunk/Source/WebKit2/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectBase.mm (186062 => 186063)
--- trunk/Source/WebKit2/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectBase.mm 2015-06-29 04:47:46 UTC (rev 186062)
+++ trunk/Source/WebKit2/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectBase.mm 2015-06-29 05:05:37 UTC (rev 186063)
@@ -54,6 +54,9 @@
if (!WebCore::AXObjectCache::accessibilityEnabled())
WebCore::AXObjectCache::enableAccessibility();
+ if (!m_page)
+ return nil;
+
NSObject* mainFramePluginAccessibilityObjectWrapper = m_page->accessibilityObjectForMainFramePlugin();
if (mainFramePluginAccessibilityObjectWrapper)
return mainFramePluginAccessibilityObjectWrapper;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
