Title: [186178] trunk/Source/WebKit2
- Revision
- 186178
- Author
- beid...@apple.com
- Date
- 2015-07-01 09:53:20 -0700 (Wed, 01 Jul 2015)
Log Message
Check shouldOpenExternalURLs instead of isProcessingUserGesture before passing URL to LaunchServices.
<rdar://problem/20577859> and https://bugs.webkit.org/show_bug.cgi?id=146513
Reviewed by Darin Adler.
* UIProcess/Cocoa/NavigationState.mm:
(WebKit::tryAppLink): The expected value of isProcessingUserGesture is lost over redirects.
shouldOpenExternalURLs actually fits this role perfectly.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (186177 => 186178)
--- trunk/Source/WebKit2/ChangeLog 2015-07-01 15:54:41 UTC (rev 186177)
+++ trunk/Source/WebKit2/ChangeLog 2015-07-01 16:53:20 UTC (rev 186178)
@@ -1,3 +1,14 @@
+2015-07-01 Brady Eidson <beid...@apple.com>
+
+ Check shouldOpenExternalURLs instead of isProcessingUserGesture before passing URL to LaunchServices.
+ <rdar://problem/20577859> and https://bugs.webkit.org/show_bug.cgi?id=146513
+
+ Reviewed by Darin Adler.
+
+ * UIProcess/Cocoa/NavigationState.mm:
+ (WebKit::tryAppLink): The expected value of isProcessingUserGesture is lost over redirects.
+ shouldOpenExternalURLs actually fits this role perfectly.
+
2015-07-01 Michael Catanzaro <mcatanz...@igalia.com>
[GTK] [Wayland] Build broken with ENABLE_WAYLAND_TARGET=ON
Modified: trunk/Source/WebKit2/UIProcess/Cocoa/NavigationState.mm (186177 => 186178)
--- trunk/Source/WebKit2/UIProcess/Cocoa/NavigationState.mm 2015-07-01 15:54:41 UTC (rev 186177)
+++ trunk/Source/WebKit2/UIProcess/Cocoa/NavigationState.mm 2015-07-01 16:53:20 UTC (rev 186178)
@@ -234,8 +234,8 @@
{
#if HAVE(APP_LINKS)
bool mainFrameNavigation = !navigationAction->targetFrame() || navigationAction->targetFrame()->isMainFrame();
- bool isProcessingUserGesture = navigationAction->isProcessingUserGesture();
- if (mainFrameNavigation && isProcessingUserGesture) {
+ bool shouldOpenExternalURLs = navigationAction->shouldOpenExternalURLs();
+ if (mainFrameNavigation && shouldOpenExternalURLs) {
auto* localCompletionHandler = new std::function<void (bool)>(WTF::move(completionHandler));
[LSAppLink openWithURL:navigationAction->request().url() completionHandler:[localCompletionHandler](BOOL success, NSError *) {
dispatch_async(dispatch_get_main_queue(), [localCompletionHandler, success] {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
