Title: [186204] trunk/Source/WebKit2
- Revision
- 186204
- Author
- [email protected]
- Date
- 2015-07-01 17:00:12 -0700 (Wed, 01 Jul 2015)
Log Message
Remove code to recompute rounded window corners
https://bugs.webkit.org/show_bug.cgi?id=146534
Reviewed by Simon Fraser.
This code is no longer needed since we're always layer-backed now.
* UIProcess/API/mac/WKView.mm:
(-[WKView displayIfNeeded]): Deleted.
(-[WKView _cacheWindowBottomCornerRect]): Deleted.
* UIProcess/API/mac/WKViewInternal.h:
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (186203 => 186204)
--- trunk/Source/WebKit2/ChangeLog 2015-07-01 23:36:53 UTC (rev 186203)
+++ trunk/Source/WebKit2/ChangeLog 2015-07-02 00:00:12 UTC (rev 186204)
@@ -1,3 +1,17 @@
+2015-07-01 Anders Carlsson <[email protected]>
+
+ Remove code to recompute rounded window corners
+ https://bugs.webkit.org/show_bug.cgi?id=146534
+
+ Reviewed by Simon Fraser.
+
+ This code is no longer needed since we're always layer-backed now.
+
+ * UIProcess/API/mac/WKView.mm:
+ (-[WKView displayIfNeeded]): Deleted.
+ (-[WKView _cacheWindowBottomCornerRect]): Deleted.
+ * UIProcess/API/mac/WKViewInternal.h:
+
2015-07-01 Yongjun Zhang <[email protected]>
Web page doesn't update its loading state when web process becomes suspended if there are pending network requests (XHR).
Modified: trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm (186203 => 186204)
--- trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm 2015-07-01 23:36:53 UTC (rev 186203)
+++ trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm 2015-07-02 00:00:12 UTC (rev 186204)
@@ -126,8 +126,6 @@
@end
@interface NSWindow (WKNSWindowDetails)
-- (NSRect)_intersectBottomCornersWithRect:(NSRect)viewRect;
-- (void)_maskRoundedBottomCorners:(NSRect)clipRect;
- (id)_newFirstResponderAfterResigning;
@end
@@ -236,8 +234,6 @@
BOOL _inSecureInputState;
- NSRect _windowBottomCornerIntersectionRect;
-
BOOL _shouldDeferViewInWindowChanges;
NSWindow *_targetWindowForMovePreparation;
@@ -1201,25 +1197,6 @@
_data->_page->capitalizeWord();
}
-- (void)displayIfNeeded
-{
- // FIXME: We should remove this code when <rdar://problem/9362085> is resolved. In the meantime,
- // it is necessary to disable scren updates so we get a chance to redraw the corners before this
- // display is visible.
- NSWindow *window = [self window];
- BOOL shouldMaskWindow = window && !NSIsEmptyRect(_data->_windowBottomCornerIntersectionRect);
- if (shouldMaskWindow)
- NSDisableScreenUpdates();
-
- [super displayIfNeeded];
-
- if (shouldMaskWindow) {
- [window _maskRoundedBottomCorners:_data->_windowBottomCornerIntersectionRect];
- NSEnableScreenUpdates();
- _data->_windowBottomCornerIntersectionRect = NSZeroRect;
- }
-}
-
// Events
// Override this so that AppKit will send us arrow keys as key down events so we can
@@ -3728,18 +3705,6 @@
[self invalidateIntrinsicContentSize];
}
-- (void)_cacheWindowBottomCornerRect
-{
- // FIXME: We should remove this code when <rdar://problem/9362085> is resolved.
- NSWindow *window = [self window];
- if (!window)
- return;
-
- _data->_windowBottomCornerIntersectionRect = [window _intersectBottomCornersWithRect:[self convertRect:[self visibleRect] toView:nil]];
- if (!NSIsEmptyRect(_data->_windowBottomCornerIntersectionRect))
- [self setNeedsDisplayInRect:[self convertRect:_data->_windowBottomCornerIntersectionRect fromView:nil]];
-}
-
- (NSInteger)spellCheckerDocumentTag
{
if (!_data->_hasSpellCheckerDocumentTag) {
Modified: trunk/Source/WebKit2/UIProcess/API/mac/WKViewInternal.h (186203 => 186204)
--- trunk/Source/WebKit2/UIProcess/API/mac/WKViewInternal.h 2015-07-01 23:36:53 UTC (rev 186203)
+++ trunk/Source/WebKit2/UIProcess/API/mac/WKViewInternal.h 2015-07-02 00:00:12 UTC (rev 186204)
@@ -112,8 +112,6 @@
- (WebKit::ColorSpaceData)_colorSpace;
-- (void)_cacheWindowBottomCornerRect;
-
- (NSInteger)spellCheckerDocumentTag;
- (void)handleAcceptedAlternativeText:(NSString*)text;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
