Title: [186693] trunk/Source/WebKit2
Revision
186693
Author
[email protected]
Date
2015-07-10 15:29:07 -0700 (Fri, 10 Jul 2015)

Log Message

Use CoreAnimation fences instead of synchronous IPC to synchronize resize
https://bugs.webkit.org/show_bug.cgi?id=146294
<rdar://problem/21090193>

Reviewed by Anders Carlsson.

* UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:
(WebKit::TiledCoreAnimationDrawingAreaProxy::createFenceForGeometryUpdate):
Tiny followup; don't touch Connection if the connection isn't valid.

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (186692 => 186693)


--- trunk/Source/WebKit2/ChangeLog	2015-07-10 22:04:50 UTC (rev 186692)
+++ trunk/Source/WebKit2/ChangeLog	2015-07-10 22:29:07 UTC (rev 186693)
@@ -1,3 +1,15 @@
+2015-07-10  Tim Horton  <[email protected]>
+
+        Use CoreAnimation fences instead of synchronous IPC to synchronize resize
+        https://bugs.webkit.org/show_bug.cgi?id=146294
+        <rdar://problem/21090193>
+
+        Reviewed by Anders Carlsson.
+
+        * UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:
+        (WebKit::TiledCoreAnimationDrawingAreaProxy::createFenceForGeometryUpdate):
+        Tiny followup; don't touch Connection if the connection isn't valid.
+
 2015-07-10  Chris Dumez  <[email protected]>
 
         [WK2] Increase the QoS of some of our WorkQueues to match the one of our processes

Modified: trunk/Source/WebKit2/UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm (186692 => 186693)


--- trunk/Source/WebKit2/UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm	2015-07-10 22:04:50 UTC (rev 186692)
+++ trunk/Source/WebKit2/UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm	2015-07-10 22:29:07 UTC (rev 186693)
@@ -153,6 +153,9 @@
 MachSendRight TiledCoreAnimationDrawingAreaProxy::createFenceForGeometryUpdate()
 {
 #if HAVE(COREANIMATION_FENCES)
+    if (!m_webPageProxy.isValid())
+        return MachSendRight();
+
     RetainPtr<CAContext> rootLayerContext = [asLayer(m_webPageProxy.acceleratedCompositingRootLayer()) context];
     if (!rootLayerContext)
         return MachSendRight();
@@ -173,6 +176,8 @@
     });
     RefPtr<WebPageProxy> retainedPage = &m_webPageProxy;
     [CATransaction addCommitHandler:[callbackID, retainedPage] {
+        if (!retainedPage->isValid())
+            return;
         if (Connection* connection = retainedPage->process().connection())
             connection->uninstallIncomingSyncMessageCallback(callbackID);
     } forPhase:kCATransactionPhasePostCommit];
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to