Title: [186704] trunk/Source/WebCore
- Revision
- 186704
- Author
- [email protected]
- Date
- 2015-07-10 20:45:19 -0700 (Fri, 10 Jul 2015)
Log Message
Cleanup: Remove default constructor for WebCore::Pair()
https://bugs.webkit.org/show_bug.cgi?id=146856
<rdar://problem/21773212>
Reviewed by Darin Adler.
Remove default constructor for WebCore::Pair() and the setters Pair::set{First, Second}()
since they are not used and it seems weird to keep the latter after the removal of the former.
Should it turn out that we find a use for having a default constructor and/or setters then
we can revert this change.
* css/Pair.h:
(WebCore::Pair::create): Deleted.
(WebCore::Pair::setFirst): Deleted.
(WebCore::Pair::setSecond): Deleted.
(WebCore::Pair::Pair): Deleted.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (186703 => 186704)
--- trunk/Source/WebCore/ChangeLog 2015-07-11 03:43:51 UTC (rev 186703)
+++ trunk/Source/WebCore/ChangeLog 2015-07-11 03:45:19 UTC (rev 186704)
@@ -1,3 +1,22 @@
+2015-07-10 Daniel Bates <[email protected]>
+
+ Cleanup: Remove default constructor for WebCore::Pair()
+ https://bugs.webkit.org/show_bug.cgi?id=146856
+ <rdar://problem/21773212>
+
+ Reviewed by Darin Adler.
+
+ Remove default constructor for WebCore::Pair() and the setters Pair::set{First, Second}()
+ since they are not used and it seems weird to keep the latter after the removal of the former.
+ Should it turn out that we find a use for having a default constructor and/or setters then
+ we can revert this change.
+
+ * css/Pair.h:
+ (WebCore::Pair::create): Deleted.
+ (WebCore::Pair::setFirst): Deleted.
+ (WebCore::Pair::setSecond): Deleted.
+ (WebCore::Pair::Pair): Deleted.
+
2015-07-10 Ryuan Choi <[email protected]>
[CoordinatedGraphics] Override primaryLayerID in CoordinatedGraphicsLayer
Modified: trunk/Source/WebCore/css/Pair.h (186703 => 186704)
--- trunk/Source/WebCore/css/Pair.h 2015-07-11 03:43:51 UTC (rev 186703)
+++ trunk/Source/WebCore/css/Pair.h 2015-07-11 03:45:19 UTC (rev 186704)
@@ -39,10 +39,6 @@
Coalesce
};
- static Ref<Pair> create()
- {
- return adoptRef(*new Pair);
- }
static Ref<Pair> create(RefPtr<CSSPrimitiveValue>&& first, RefPtr<CSSPrimitiveValue>&& second)
{
return adoptRef(*new Pair(WTF::move(first), WTF::move(second)));
@@ -56,9 +52,6 @@
CSSPrimitiveValue* first() const { return m_first.get(); }
CSSPrimitiveValue* second() const { return m_second.get(); }
- void setFirst(RefPtr<CSSPrimitiveValue>&& first) { m_first = WTF::move(first); }
- void setSecond(RefPtr<CSSPrimitiveValue>&& second) { m_second = WTF::move(second); }
-
String cssText() const
{
String first = this->first()->cssText();
@@ -71,7 +64,6 @@
bool equals(const Pair& other) const { return compareCSSValuePtr(m_first, other.m_first) && compareCSSValuePtr(m_second, other.m_second); }
private:
- Pair() : m_first(nullptr), m_second(nullptr) { }
Pair(RefPtr<CSSPrimitiveValue>&& first, RefPtr<CSSPrimitiveValue>&& second) : m_first(WTF::move(first)), m_second(WTF::move(second)) { }
Pair(RefPtr<CSSPrimitiveValue>&& first, RefPtr<CSSPrimitiveValue>&& second, IdenticalValueEncoding encoding) : m_first(WTF::move(first)), m_second(WTF::move(second)), m_encoding(encoding) { }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
