Title: [186796] trunk/Source/WebInspectorUI
Revision
186796
Author
[email protected]
Date
2015-07-13 16:53:14 -0700 (Mon, 13 Jul 2015)

Log Message

Web Inspector: Uncaught exception in inspector for some ConsoleMessages
https://bugs.webkit.org/show_bug.cgi?id=146919

Patch by Joseph Pecoraro <[email protected]> on 2015-07-13
Reviewed by Brian Burg.

* UserInterface/Views/ConsoleMessageView.js:
(WebInspector.ConsoleMessageView.prototype._appendLocationLink):
The parameters list may not exist, so null check it before use.

Modified Paths

Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (186795 => 186796)


--- trunk/Source/WebInspectorUI/ChangeLog	2015-07-13 23:27:30 UTC (rev 186795)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-07-13 23:53:14 UTC (rev 186796)
@@ -1,3 +1,14 @@
+2015-07-13  Joseph Pecoraro  <[email protected]>
+
+        Web Inspector: Uncaught exception in inspector for some ConsoleMessages
+        https://bugs.webkit.org/show_bug.cgi?id=146919
+
+        Reviewed by Brian Burg.
+
+        * UserInterface/Views/ConsoleMessageView.js:
+        (WebInspector.ConsoleMessageView.prototype._appendLocationLink):
+        The parameters list may not exist, so null check it before use.
+
 2015-07-13  Nikita Vasilyev  <[email protected]>
 
         Web Inspector: Use -apple-system-monospaced-numbers for line numbers

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js (186795 => 186796)


--- trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js	2015-07-13 23:27:30 UTC (rev 186795)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js	2015-07-13 23:53:14 UTC (rev 186796)
@@ -322,7 +322,7 @@
             return;
         }
 
-        if (this._message.parameters.length === 1) {
+        if (this._message.parameters && this._message.parameters.length === 1) {
             var parameter = this._createRemoteObjectIfNeeded(this._message.parameters[0]);
 
             parameter.findFunctionSourceCodeLocation().then(function(result) {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to