Title: [186851] branches/jsc-tailcall/Source/_javascript_Core
- Revision
- 186851
- Author
- [email protected]
- Date
- 2015-07-15 11:32:29 -0700 (Wed, 15 Jul 2015)
Log Message
jsc-tailcall: Change sizeof(Register) to sizeof(void*)
Rubber-stamped by Michael Saboff.
sizeof(void*) is the actual size of a pointer on the current
architecture, while sizeof(Register) is the size of a 64-bit JS slot.
They are the technically the same since FTL only works on 64-bit
architectures, but we should still use the semantically correct one.
* ftl/FTLJSCall.cpp:
(JSC::FTL::JSCall::emit):
Modified Paths
Diff
Modified: branches/jsc-tailcall/Source/_javascript_Core/ChangeLog (186850 => 186851)
--- branches/jsc-tailcall/Source/_javascript_Core/ChangeLog 2015-07-15 18:02:50 UTC (rev 186850)
+++ branches/jsc-tailcall/Source/_javascript_Core/ChangeLog 2015-07-15 18:32:29 UTC (rev 186851)
@@ -1,5 +1,19 @@
2015-07-15 Basile Clement <[email protected]>
+ jsc-tailcall: Change sizeof(Register) to sizeof(void*)
+
+ Rubber-stamped by Michael Saboff.
+
+ sizeof(void*) is the actual size of a pointer on the current
+ architecture, while sizeof(Register) is the size of a 64-bit JS slot.
+ They are the technically the same since FTL only works on 64-bit
+ architectures, but we should still use the semantically correct one.
+
+ * ftl/FTLJSCall.cpp:
+ (JSC::FTL::JSCall::emit):
+
+2015-07-15 Basile Clement <[email protected]>
+
jsc-tailcall: Only non-constructors functions are candidate for tail calls
https://bugs.webkit.org/show_bug.cgi?id=146967
Modified: branches/jsc-tailcall/Source/_javascript_Core/ftl/FTLJSCall.cpp (186850 => 186851)
--- branches/jsc-tailcall/Source/_javascript_Core/ftl/FTLJSCall.cpp 2015-07-15 18:02:50 UTC (rev 186850)
+++ branches/jsc-tailcall/Source/_javascript_Core/ftl/FTLJSCall.cpp 2015-07-15 18:32:29 UTC (rev 186851)
@@ -56,7 +56,7 @@
JSCallBase::emit(jit);
// Restore the stack pointer
- jit.addPtr(CCallHelpers::TrustedImm32(sizeof(Register) - static_cast<int64_t>(stackSize)), CCallHelpers::framePointerRegister, CCallHelpers::stackPointerRegister);
+ jit.addPtr(CCallHelpers::TrustedImm32(sizeof(void*) - static_cast<int64_t>(stackSize)), CCallHelpers::framePointerRegister, CCallHelpers::stackPointerRegister);
}
} } // namespace JSC::FTL
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
