Title: [187052] trunk/Source/WebInspectorUI
- Revision
- 187052
- Author
- [email protected]
- Date
- 2015-07-20 17:58:38 -0700 (Mon, 20 Jul 2015)
Log Message
Web Inspector: console.assert(false, "Message") message is not visible in console
https://bugs.webkit.org/show_bug.cgi?id=147130
Patch by Joseph Pecoraro <[email protected]> on 2015-07-20
Reviewed by Timothy Hatcher.
* Localizations/en.lproj/localizedStrings.js:
* UserInterface/Views/ConsoleMessageView.js:
(WebInspector.ConsoleMessageView.prototype._appendMessageTextAndArguments):
We were forgetting to assign the result of args.concat back into args.
In re-addressing this, improve the formatting of output if there is
a string message or not as the second argument to console.assert(), as
that is the common usage.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (187051 => 187052)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-07-21 00:27:56 UTC (rev 187051)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-07-21 00:58:38 UTC (rev 187052)
@@ -1,3 +1,18 @@
+2015-07-20 Joseph Pecoraro <[email protected]>
+
+ Web Inspector: console.assert(false, "Message") message is not visible in console
+ https://bugs.webkit.org/show_bug.cgi?id=147130
+
+ Reviewed by Timothy Hatcher.
+
+ * Localizations/en.lproj/localizedStrings.js:
+ * UserInterface/Views/ConsoleMessageView.js:
+ (WebInspector.ConsoleMessageView.prototype._appendMessageTextAndArguments):
+ We were forgetting to assign the result of args.concat back into args.
+ In re-addressing this, improve the formatting of output if there is
+ a string message or not as the second argument to console.assert(), as
+ that is the common usage.
+
2015-07-18 Saam barati <[email protected]>
[ES6] Add support for block scope const
Modified: trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (187051 => 187052)
--- trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2015-07-21 00:27:56 UTC (rev 187051)
+++ trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2015-07-21 00:58:38 UTC (rev 187052)
@@ -67,7 +67,7 @@
localizedStrings["Application Cache"] = "Application Cache";
localizedStrings["Assertion"] = "Assertion";
localizedStrings["Assertion Failed"] = "Assertion Failed";
-localizedStrings["Assertion failed:"] = "Assertion failed:";
+localizedStrings["Assertion Failed: %s"] = "Assertion Failed: %s";
localizedStrings["Assertion with message: %s"] = "Assertion with message: %s";
localizedStrings["Assertive"] = "Assertive";
localizedStrings["Attribute"] = "Attribute";
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js (187051 => 187052)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js 2015-07-21 00:27:56 UTC (rev 187051)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js 2015-07-21 00:58:38 UTC (rev 187052)
@@ -232,9 +232,13 @@
break;
case WebInspector.ConsoleMessage.MessageType.Assert:
- var args = [WebInspector.UIString("Assertion failed:")];
- if (this._message.parameters)
- args.concat(this._message.parameters);
+ var args = [WebInspector.UIString("Assertion Failed")];
+ if (this._message.parameters) {
+ if (this._message.parameters[0].type === "string")
+ args = [WebInspector.UIString("Assertion Failed: %s")].concat(this._message.parameters);
+ else
+ args = args.concat(this._message.parameters);
+ }
this._appendFormattedArguments(element, args);
break;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
