Title: [187270] trunk/Source/bmalloc
Revision
187270
Author
[email protected]
Date
2015-07-23 16:33:05 -0700 (Thu, 23 Jul 2015)

Log Message

bmalloc: Shrink the super chunk size (again)
https://bugs.webkit.org/show_bug.cgi?id=147240

Reviewed by Andreas Kling.

Shrinking to 8MB reduced VM exhaustion crashes but did not eliminate them.
Let's try 4MB.

(My previous comment was that the maximum fast object was 2MB. But it
was 4MB! Now it's 2MB for realsies.)

* bmalloc/Sizes.h:

Modified Paths

Diff

Modified: trunk/Source/bmalloc/ChangeLog (187269 => 187270)


--- trunk/Source/bmalloc/ChangeLog	2015-07-23 23:20:31 UTC (rev 187269)
+++ trunk/Source/bmalloc/ChangeLog	2015-07-23 23:33:05 UTC (rev 187270)
@@ -1,3 +1,18 @@
+2015-07-23  Geoffrey Garen  <[email protected]>
+
+        bmalloc: Shrink the super chunk size (again)
+        https://bugs.webkit.org/show_bug.cgi?id=147240
+
+        Reviewed by Andreas Kling.
+
+        Shrinking to 8MB reduced VM exhaustion crashes but did not eliminate them.
+        Let's try 4MB.
+
+        (My previous comment was that the maximum fast object was 2MB. But it
+        was 4MB! Now it's 2MB for realsies.)
+
+        * bmalloc/Sizes.h:
+
 2015-07-03  Dan Bernstein  <[email protected]>
 
         [Xcode] Update some build settings as recommended by Xcode 7

Modified: trunk/Source/bmalloc/bmalloc/SegregatedFreeList.h (187269 => 187270)


--- trunk/Source/bmalloc/bmalloc/SegregatedFreeList.h	2015-07-23 23:20:31 UTC (rev 187269)
+++ trunk/Source/bmalloc/bmalloc/SegregatedFreeList.h	2015-07-23 23:33:05 UTC (rev 187270)
@@ -60,7 +60,7 @@
     FreeList& select(size_t);
 
     Owner m_owner;
-    std::array<FreeList, 17> m_freeLists;
+    std::array<FreeList, 16> m_freeLists;
 };
 
 } // namespace bmalloc

Modified: trunk/Source/bmalloc/bmalloc/Sizes.h (187269 => 187270)


--- trunk/Source/bmalloc/bmalloc/Sizes.h	2015-07-23 23:20:31 UTC (rev 187269)
+++ trunk/Source/bmalloc/bmalloc/Sizes.h	2015-07-23 23:33:05 UTC (rev 187270)
@@ -53,7 +53,7 @@
 #endif
     static const size_t vmPageMask = ~(vmPageSize - 1);
     
-    static const size_t superChunkSize = 8 * MB;
+    static const size_t superChunkSize = 4 * MB;
 
     static const size_t smallMax = 256;
     static const size_t smallLineSize = 256;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to