[webkit-changes] [187292] branches/safari-601.1-branch

Thu, 23 Jul 2015 23:04:55 -0700

Title: [187292] branches/safari-601.1-branch

Diff

Modified: branches/safari-601.1-branch/LayoutTests/ChangeLog (187291 => 187292)


--- branches/safari-601.1-branch/LayoutTests/ChangeLog	2015-07-24 06:01:33 UTC (rev 187291)
+++ branches/safari-601.1-branch/LayoutTests/ChangeLog	2015-07-24 06:04:32 UTC (rev 187292)
@@ -1,3 +1,22 @@
+2015-07-23  Lucas Forschler  <[email protected]>
+
+        Merge r186981
+
+    2015-07-17  Zalan Bujtas  <[email protected]>
+
+            (display: block)input range's thumb disappears when moved.
+            https://bugs.webkit.org/show_bug.cgi?id=146896
+            <rdar://problem/21787807>
+
+            Reviewed by Simon Fraser.
+
+            Since the thumb is positioned after the layout for the input (shadow) subtree is finished, the repaint rects
+            issued during the layout will not cover the re-positioned thumb.
+            We need to issue a repaint soon after the thumb is re-positioned.
+
+            * fast/repaint/block-inputrange-repaint-expected.txt: Added.
+            * fast/repaint/block-inputrange-repaint.html: Added.
+
 2015-07-23  Alexey Proskuryakov  <[email protected]>
 
         Merge r186900.

Copied: branches/safari-601.1-branch/LayoutTests/fast/repaint/block-inputrange-repaint-expected.txt (from rev 186981, trunk/LayoutTests/fast/repaint/block-inputrange-repaint-expected.txt) (0 => 187292)


--- branches/safari-601.1-branch/LayoutTests/fast/repaint/block-inputrange-repaint-expected.txt	                        (rev 0)
+++ branches/safari-601.1-branch/LayoutTests/fast/repaint/block-inputrange-repaint-expected.txt	2015-07-24 06:04:32 UTC (rev 187292)
@@ -0,0 +1,5 @@
+PASS repaintRects.indexOf('495 8 15 15') is not -1
+PASS successfullyParsed is true
+
+TEST COMPLETE
+

Copied: branches/safari-601.1-branch/LayoutTests/fast/repaint/block-inputrange-repaint.html (from rev 186981, trunk/LayoutTests/fast/repaint/block-inputrange-repaint.html) (0 => 187292)


--- branches/safari-601.1-branch/LayoutTests/fast/repaint/block-inputrange-repaint.html	                        (rev 0)
+++ branches/safari-601.1-branch/LayoutTests/fast/repaint/block-inputrange-repaint.html	2015-07-24 06:04:32 UTC (rev 187292)
@@ -0,0 +1,28 @@
+<!DOCTYPE html>
+<head>
+<title>This tests when input=range is block we issue correct repaint rects</title>
+<script>jsTestIsAsync = true;</script>
+<script src=""
+<style>
+  input[type="range"] {
+    display: block;
+    width: 500px;
+  }
+</style>
+</head>
+<body>
+<input id=moveme type=range>
+<script>
+  window.internals.startTrackingRepaints();
+  document.getElementById("moveme").value = 100;
+  document.body.offsetHeight;
+  if (window.internals) {
+    repaintRects = window.internals.repaintRectsAsText();
+    window.internals.stopTrackingRepaints();
+    shouldNotBe("repaintRects.indexOf('495 8 15 15')", "-1");
+    finishJSTest();
+  }
+</script>
+</body>
+<script src=""
+</html>

Modified: branches/safari-601.1-branch/Source/WebCore/ChangeLog (187291 => 187292)


--- branches/safari-601.1-branch/Source/WebCore/ChangeLog	2015-07-24 06:01:33 UTC (rev 187291)
+++ branches/safari-601.1-branch/Source/WebCore/ChangeLog	2015-07-24 06:04:32 UTC (rev 187292)
@@ -1,3 +1,24 @@
+2015-07-23  Lucas Forschler  <[email protected]>
+
+        Merge r186981
+
+    2015-07-17  Zalan Bujtas  <[email protected]>
+
+            (display: block)input range's thumb disappears when moved.
+            https://bugs.webkit.org/show_bug.cgi?id=146896
+            <rdar://problem/21787807>
+
+            Reviewed by Simon Fraser.
+
+            Since the thumb is positioned after the layout for the input (shadow) subtree is finished, the repaint rects
+            issued during the layout will not cover the re-positioned thumb.
+            We need to issue a repaint soon after the thumb is re-positioned.
+
+            Test: fast/repaint/block-inputrange-repaint.html
+
+            * html/shadow/SliderThumbElement.cpp:
+            (WebCore::RenderSliderContainer::layout):
+
 2015-07-23  Alexey Proskuryakov  <[email protected]>
 
         Merge r186677, which is a follow-up fix to r186642.

Modified: branches/safari-601.1-branch/Source/WebCore/html/shadow/SliderThumbElement.cpp (187291 => 187292)


--- branches/safari-601.1-branch/Source/WebCore/html/shadow/SliderThumbElement.cpp	2015-07-24 06:01:33 UTC (rev 187291)
+++ branches/safari-601.1-branch/Source/WebCore/html/shadow/SliderThumbElement.cpp	2015-07-24 06:04:32 UTC (rev 187292)
@@ -190,6 +190,7 @@
     else
         thumbLocation.setX(thumbLocation.x() - offset);
     thumb->setLocation(thumbLocation);
+    thumb->repaint();
 }
 
 // --------------------------------

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to