Title: [187310] branches/safari-601.1-branch/Source/WebCore
Revision
187310
Author
[email protected]
Date
2015-07-24 00:54:04 -0700 (Fri, 24 Jul 2015)

Log Message

Merge r187170. rdar://problem/21901076

Modified Paths

Diff

Modified: branches/safari-601.1-branch/Source/WebCore/ChangeLog (187309 => 187310)


--- branches/safari-601.1-branch/Source/WebCore/ChangeLog	2015-07-24 07:54:02 UTC (rev 187309)
+++ branches/safari-601.1-branch/Source/WebCore/ChangeLog	2015-07-24 07:54:04 UTC (rev 187310)
@@ -1,5 +1,26 @@
 2015-07-24  Matthew Hanson  <[email protected]>
 
+        Merge r187170. rdar://problem/21901076
+
+    2015-07-22  Wenson Hsieh  <[email protected]>
+
+            Search fields render placeholder text improperly.
+            https://bugs.webkit.org/show_bug.cgi?id=147192
+            <rdar://problem/21901076>
+
+            Reviewed by Alexey Proskuryakov.
+
+            Due to changes in the way AppKit renders search inputs, we must now explicitly
+            set the placeholder text of a search input rendered using the Mac theme to be
+            an empty string when rendering the search input box (not including the actual
+            placeholder text).
+
+            * rendering/RenderThemeMac.mm:
+            (WebCore::RenderThemeMac::setSearchCellState): Force the placeholder text of
+                the NSSearchFieldCell for the Mac theme to be an empty string.
+
+2015-07-24  Matthew Hanson  <[email protected]>
+
         Merge r187144. rdar://problem/21931728
 
     2015-07-21  Dean Jackson  <[email protected]>

Modified: branches/safari-601.1-branch/Source/WebCore/rendering/RenderThemeMac.mm (187309 => 187310)


--- branches/safari-601.1-branch/Source/WebCore/rendering/RenderThemeMac.mm	2015-07-24 07:54:02 UTC (rev 187309)
+++ branches/safari-601.1-branch/Source/WebCore/rendering/RenderThemeMac.mm	2015-07-24 07:54:04 UTC (rev 187310)
@@ -1631,6 +1631,7 @@
 {
     NSSearchFieldCell* search = this->search();
 
+    [search setPlaceholderString:@""];
     [search setControlSize:controlSizeForFont(o.style())];
 
     // Update the various states we respond to.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to