Title: [187398] trunk/Source/WebCore
- Revision
- 187398
- Author
- [email protected]
- Date
- 2015-07-25 19:13:33 -0700 (Sat, 25 Jul 2015)
Log Message
Remove an never failing check for client() in ResourceHandle::canAuthenticateAgainstProtectionSpace.
Requested by Brady Eidson in bug 147277.
* platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::canAuthenticateAgainstProtectionSpace):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (187397 => 187398)
--- trunk/Source/WebCore/ChangeLog 2015-07-26 02:09:59 UTC (rev 187397)
+++ trunk/Source/WebCore/ChangeLog 2015-07-26 02:13:33 UTC (rev 187398)
@@ -1,3 +1,12 @@
+2015-07-25 Alexey Proskuryakov <[email protected]>
+
+ Remove an never failing check for client() in ResourceHandle::canAuthenticateAgainstProtectionSpace.
+
+ Requested by Brady Eidson in bug 147277.
+
+ * platform/network/mac/ResourceHandleMac.mm:
+ (WebCore::ResourceHandle::canAuthenticateAgainstProtectionSpace):
+
2015-07-25 Tim Horton <[email protected]>
Expose TextIndicator-backed snapshot and rect gathering on DOMNode
Modified: trunk/Source/WebCore/platform/network/mac/ResourceHandleMac.mm (187397 => 187398)
--- trunk/Source/WebCore/platform/network/mac/ResourceHandleMac.mm 2015-07-26 02:09:59 UTC (rev 187397)
+++ trunk/Source/WebCore/platform/network/mac/ResourceHandleMac.mm 2015-07-26 02:13:33 UTC (rev 187398)
@@ -632,11 +632,7 @@
bool ResourceHandle::canAuthenticateAgainstProtectionSpace(const ProtectionSpace& protectionSpace)
{
if (client()->usesAsyncCallbacks()) {
- // FIXME: This check for client() being null makes no sense.
- if (client())
- client()->canAuthenticateAgainstProtectionSpaceAsync(this, protectionSpace);
- else
- continueCanAuthenticateAgainstProtectionSpace(false);
+ client()->canAuthenticateAgainstProtectionSpaceAsync(this, protectionSpace);
return false; // Ignored by caller.
} else
return client() && client()->canAuthenticateAgainstProtectionSpace(this, protectionSpace);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
