Title: [187405] trunk/Source/WebInspectorUI
- Revision
- 187405
- Author
- [email protected]
- Date
- 2015-07-25 23:30:37 -0700 (Sat, 25 Jul 2015)
Log Message
Web Inspector: Start using Node.prototype.remove
https://bugs.webkit.org/show_bug.cgi?id=147304
Reviewed by Timothy Hatcher.
* UserInterface/Base/Main.js:
(WebInspector.elementDragStart):
(WebInspector.elementDragEnd):
(WebInspector.revertDomChanges):
* UserInterface/Views/DOMTreeElement.js:
(WebInspector.DOMTreeElement.prototype._updateSearchHighlight.updateEntryHide):
(WebInspector.DOMTreeElement.prototype._updateSearchHighlight):
(WebInspector.DOMTreeElement.prototype.remove.removeNodeCallback):
(WebInspector.DOMTreeElement.prototype.remove):
* UserInterface/Views/Resizer.js:
(WebInspector.Resizer.prototype._resizerMouseDown):
(WebInspector.Resizer.prototype._resizerMouseUp):
(WebInspector.Resizer):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (187404 => 187405)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-07-26 06:23:10 UTC (rev 187404)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-07-26 06:30:37 UTC (rev 187405)
@@ -1,5 +1,26 @@
2015-07-25 Nikita Vasilyev <[email protected]>
+ Web Inspector: Start using Node.prototype.remove
+ https://bugs.webkit.org/show_bug.cgi?id=147304
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Base/Main.js:
+ (WebInspector.elementDragStart):
+ (WebInspector.elementDragEnd):
+ (WebInspector.revertDomChanges):
+ * UserInterface/Views/DOMTreeElement.js:
+ (WebInspector.DOMTreeElement.prototype._updateSearchHighlight.updateEntryHide):
+ (WebInspector.DOMTreeElement.prototype._updateSearchHighlight):
+ (WebInspector.DOMTreeElement.prototype.remove.removeNodeCallback):
+ (WebInspector.DOMTreeElement.prototype.remove):
+ * UserInterface/Views/Resizer.js:
+ (WebInspector.Resizer.prototype._resizerMouseDown):
+ (WebInspector.Resizer.prototype._resizerMouseUp):
+ (WebInspector.Resizer):
+
+2015-07-25 Nikita Vasilyev <[email protected]>
+
Web Inspector: Fix color declaration for not-executed comments
https://bugs.webkit.org/show_bug.cgi?id=147305
Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Main.js (187404 => 187405)
--- trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2015-07-26 06:23:10 UTC (rev 187404)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2015-07-26 06:30:37 UTC (rev 187405)
@@ -1703,7 +1703,7 @@
if (element) {
// Install glass pane
if (WebInspector._elementDraggingGlassPane)
- WebInspector._elementDraggingGlassPane.parentElement.removeChild(WebInspector._elementDraggingGlassPane);
+ WebInspector._elementDraggingGlassPane.remove();
var glassPane = document.createElement("div");
glassPane.style.cssText = "position:absolute;top:0;bottom:0;left:0;right:0;opacity:0;z-index:1";
@@ -1734,7 +1734,7 @@
event.target.ownerDocument.body.style.removeProperty("cursor");
if (WebInspector._elementDraggingGlassPane)
- WebInspector._elementDraggingGlassPane.parentElement.removeChild(WebInspector._elementDraggingGlassPane);
+ WebInspector._elementDraggingGlassPane.remove();
delete WebInspector._elementDraggingGlassPane;
delete WebInspector._elementDraggingEventTarget;
@@ -2027,8 +2027,7 @@
var entry = domChanges[i];
switch (entry.type) {
case "added":
- if (entry.node.parentElement)
- entry.node.parentElement.removeChild(entry.node);
+ entry.node.remove();
break;
case "changed":
entry.node.textContent = entry.oldText;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js (187404 => 187405)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js 2015-07-26 06:23:10 UTC (rev 187404)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js 2015-07-26 06:30:37 UTC (rev 187405)
@@ -120,8 +120,7 @@
{
switch (entry.type) {
case "added":
- if (entry.node.parentElement)
- entry.node.parentElement.removeChild(entry.node);
+ entry.node.remove();
break;
case "changed":
entry.node.textContent = entry.oldText;
@@ -1265,7 +1264,7 @@
if (!self.parent)
return;
- parentElement.removeChild(self);
+ self.remove();
parentElement.adjustCollapsedRange();
}
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/Resizer.js (187404 => 187405)
--- trunk/Source/WebInspectorUI/UserInterface/Views/Resizer.js 2015-07-26 06:23:10 UTC (rev 187404)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/Resizer.js 2015-07-26 06:30:37 UTC (rev 187405)
@@ -110,7 +110,7 @@
// The cursor could change when hovering over links, text, or other elements with cursor cues.
// FIXME: when Pointer Events support is available this could be implemented by drawing the cursor ourselves.
if (WebInspector._elementDraggingGlassPane)
- WebInspector._elementDraggingGlassPane.parentElement.removeChild(WebInspector._elementDraggingGlassPane);
+ WebInspector._elementDraggingGlassPane.remove();
var glassPaneElement = document.createElement("div");
glassPaneElement.className = "glass-pane-for-drag";
@@ -135,7 +135,7 @@
document.body.style.removeProperty("cursor");
if (WebInspector._elementDraggingGlassPane) {
- WebInspector._elementDraggingGlassPane.parentElement.removeChild(WebInspector._elementDraggingGlassPane);
+ WebInspector._elementDraggingGlassPane.remove();
delete WebInspector._elementDraggingGlassPane;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
