Title: [187565] trunk/Source/WebKit2
- Revision
- 187565
- Author
- [email protected]
- Date
- 2015-07-29 16:03:25 -0700 (Wed, 29 Jul 2015)
Log Message
Preview should not start if touch handler prevents default.
https://bugs.webkit.org/show_bug.cgi?id=147423
rdar://problem/22061043
Reviewed by Tim Horton.
We need to check if _highlightLongPressCanClick has not been reset before
we allow the preview. It can be reset by a touch handler preventing default.
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _interactionShouldBeginFromPreviewItemController:forPosition:]):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (187564 => 187565)
--- trunk/Source/WebKit2/ChangeLog 2015-07-29 22:17:03 UTC (rev 187564)
+++ trunk/Source/WebKit2/ChangeLog 2015-07-29 23:03:25 UTC (rev 187565)
@@ -1,3 +1,17 @@
+2015-07-29 Enrica Casucci <[email protected]>
+
+ Preview should not start if touch handler prevents default.
+ https://bugs.webkit.org/show_bug.cgi?id=147423
+ rdar://problem/22061043
+
+ Reviewed by Tim Horton.
+
+ We need to check if _highlightLongPressCanClick has not been reset before
+ we allow the preview. It can be reset by a touch handler preventing default.
+
+ * UIProcess/ios/WKContentViewInteraction.mm:
+ (-[WKContentView _interactionShouldBeginFromPreviewItemController:forPosition:]):
+
2015-07-29 Chris Fleizach <[email protected]>
AX: iOS: VoiceOver hangs indefinitely when an JS alert appears
Modified: trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm (187564 => 187565)
--- trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm 2015-07-29 22:17:03 UTC (rev 187564)
+++ trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm 2015-07-29 23:03:25 UTC (rev 187565)
@@ -3225,6 +3225,9 @@
- (BOOL)_interactionShouldBeginFromPreviewItemController:(UIPreviewItemController *)controller forPosition:(CGPoint)position
{
+ if (!_highlightLongPressCanClick)
+ return NO;
+
[self ensurePositionInformationIsUpToDate:position];
if (_positionInformation.clickableElementName != "A" && _positionInformation.clickableElementName != "IMG")
return NO;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
