Title: [187669] trunk/Source/WebKit/mac
- Revision
- 187669
- Author
- beid...@apple.com
- Date
- 2015-07-31 12:43:43 -0700 (Fri, 31 Jul 2015)
Log Message
REGRESSION (r174791): Returning a zombie NSImage from sharingService:transitionImageForShareItem:contentRect:
<rdar://problem/22060183> and https://bugs.webkit.org/show_bug.cgi?id=147497
Reviewed by Tim Horton.
* WebCoreSupport/WebContextMenuClient.mm:
(WebContextMenuClient::imageForCurrentSharingServicePickerItem): Don't return what is basically a temporary NSImage.
Instead do a [[retain] autorelease] on it while still valid.
Modified Paths
Diff
Modified: trunk/Source/WebKit/mac/ChangeLog (187668 => 187669)
--- trunk/Source/WebKit/mac/ChangeLog 2015-07-31 19:25:58 UTC (rev 187668)
+++ trunk/Source/WebKit/mac/ChangeLog 2015-07-31 19:43:43 UTC (rev 187669)
@@ -1,3 +1,14 @@
+2015-07-31 Brady Eidson <beid...@apple.com>
+
+ REGRESSION (r174791): Returning a zombie NSImage from sharingService:transitionImageForShareItem:contentRect:
+ <rdar://problem/22060183> and https://bugs.webkit.org/show_bug.cgi?id=147497
+
+ Reviewed by Tim Horton.
+
+ * WebCoreSupport/WebContextMenuClient.mm:
+ (WebContextMenuClient::imageForCurrentSharingServicePickerItem): Don't return what is basically a temporary NSImage.
+ Instead do a [[retain] autorelease] on it while still valid.
+
2015-07-29 Dean Jackson <d...@apple.com>
Don't use (Details) when exposing SPI
Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.mm (187668 => 187669)
--- trunk/Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.mm 2015-07-31 19:25:58 UTC (rev 187668)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.mm 2015-07-31 19:43:43 UTC (rev 187669)
@@ -486,7 +486,7 @@
if (!image)
return nil;
- return image->getNSImage();
+ return [[image->getNSImage() retain] autorelease];
}
#endif
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
