Title: [187683] branches/jsc-tailcall/Source/_javascript_Core
- Revision
- 187683
- Author
- [email protected]
- Date
- 2015-07-31 14:40:39 -0700 (Fri, 31 Jul 2015)
Log Message
jsc-tailcall: REGRESSION(r187676): Broke stress/tail-call-no-stack-overflow.js
https://bugs.webkit.org/show_bug.cgi?id=147507
Reviewed by Basile Clement.
Changed strictLoopArityFixup1 and strictLoopArityFixup2 to recursively call
themselves instead of nonexistent strictLoopArityFixup.
* tests/stress/tail-call-no-stack-overflow.js:
(strictLoopArityFixup1):
(strictLoopArityFixup2):
Modified Paths
Diff
Modified: branches/jsc-tailcall/Source/_javascript_Core/ChangeLog (187682 => 187683)
--- branches/jsc-tailcall/Source/_javascript_Core/ChangeLog 2015-07-31 21:26:15 UTC (rev 187682)
+++ branches/jsc-tailcall/Source/_javascript_Core/ChangeLog 2015-07-31 21:40:39 UTC (rev 187683)
@@ -1,3 +1,17 @@
+2015-07-31 Michael Saboff <[email protected]>
+
+ jsc-tailcall: REGRESSION(r187676): Broke stress/tail-call-no-stack-overflow.js
+ https://bugs.webkit.org/show_bug.cgi?id=147507
+
+ Reviewed by Basile Clement.
+
+ Changed strictLoopArityFixup1 and strictLoopArityFixup2 to recursively call
+ themselves instead of nonexistent strictLoopArityFixup.
+
+ * tests/stress/tail-call-no-stack-overflow.js:
+ (strictLoopArityFixup1):
+ (strictLoopArityFixup2):
+
2015-07-31 Basile Clement <[email protected]>
jsc-tailcall: Emit a single callee-save restoration for fast and slow tail call paths
Modified: branches/jsc-tailcall/Source/_javascript_Core/tests/stress/tail-call-no-stack-overflow.js (187682 => 187683)
--- branches/jsc-tailcall/Source/_javascript_Core/tests/stress/tail-call-no-stack-overflow.js 2015-07-31 21:26:15 UTC (rev 187682)
+++ branches/jsc-tailcall/Source/_javascript_Core/tests/stress/tail-call-no-stack-overflow.js 2015-07-31 21:40:39 UTC (rev 187683)
@@ -28,13 +28,13 @@
function strictLoopArityFixup1(n, dummy) {
"use strict";
if (n > 0)
- return strictLoopArityFixup(n - 1);
+ return strictLoopArityFixup1(n - 1);
}
function strictLoopArityFixup2(n, dummy1, dummy2) {
"use strict";
if (n > 0)
- return strictLoopArityFixup(n - 1);
+ return strictLoopArityFixup2(n - 1);
}
shouldThrow(function () { sloppyLoop(100000); }, 'RangeError: Maximum call stack size exceeded.');
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
