Title: [187829] releases/WebKitGTK/webkit-2.8/Source/WebCore
Revision
187829
Author
[email protected]
Date
2015-08-04 02:23:23 -0700 (Tue, 04 Aug 2015)

Log Message

Merge r186581 - [GTK] The "Missing Plug-in" buttons are not showing up on some flash contents.
https://bugs.webkit.org/show_bug.cgi?id=146707

Patch by Sungmann Cho <[email protected]> on 2015-07-08
Reviewed by Martin Robinson.

Currently, WebKitGTK+ doesn't show the "Missing Plug-in" buttons if the plugin-related tags
don't have a "type" attribute. In such a case, WebCore tries to guess the MIME type from
the extensions by using MIMETypeRegistry::getMIMETypeForExtension(). For WebKitGTK+,
MIMETypeRegistry::getMIMETypeForExtension() goes through |extensionMap|, which is a simple
array of <extension, mime type>, looking for the mime type for the given extension.
But |extensionMap| in MIMETypeRegistryGtk.cpp doesn't have the information for ".swf",
so WebCore fails to guess the MIME type and regard the content type as ObjectContentFrame,
not ObjectContentNetscapePlugin.

* platform/gtk/MIMETypeRegistryGtk.cpp:

Modified Paths

Diff

Modified: releases/WebKitGTK/webkit-2.8/Source/WebCore/ChangeLog (187828 => 187829)


--- releases/WebKitGTK/webkit-2.8/Source/WebCore/ChangeLog	2015-08-04 09:20:34 UTC (rev 187828)
+++ releases/WebKitGTK/webkit-2.8/Source/WebCore/ChangeLog	2015-08-04 09:23:23 UTC (rev 187829)
@@ -1,3 +1,21 @@
+2015-07-08  Sungmann Cho  <[email protected]>
+
+        [GTK] The "Missing Plug-in" buttons are not showing up on some flash contents.
+        https://bugs.webkit.org/show_bug.cgi?id=146707
+
+        Reviewed by Martin Robinson.
+
+        Currently, WebKitGTK+ doesn't show the "Missing Plug-in" buttons if the plugin-related tags
+        don't have a "type" attribute. In such a case, WebCore tries to guess the MIME type from
+        the extensions by using MIMETypeRegistry::getMIMETypeForExtension(). For WebKitGTK+,
+        MIMETypeRegistry::getMIMETypeForExtension() goes through |extensionMap|, which is a simple
+        array of <extension, mime type>, looking for the mime type for the given extension.
+        But |extensionMap| in MIMETypeRegistryGtk.cpp doesn't have the information for ".swf",
+        so WebCore fails to guess the MIME type and regard the content type as ObjectContentFrame,
+        not ObjectContentNetscapePlugin.
+
+        * platform/gtk/MIMETypeRegistryGtk.cpp:
+
 2015-07-08  Said Abou-Hallawa  <[email protected]>
 
         Crash when appending an SVG <use> element dynamically which has animated SVG <path> element

Modified: releases/WebKitGTK/webkit-2.8/Source/WebCore/platform/gtk/MIMETypeRegistryGtk.cpp (187828 => 187829)


--- releases/WebKitGTK/webkit-2.8/Source/WebCore/platform/gtk/MIMETypeRegistryGtk.cpp	2015-08-04 09:20:34 UTC (rev 187828)
+++ releases/WebKitGTK/webkit-2.8/Source/WebCore/platform/gtk/MIMETypeRegistryGtk.cpp	2015-08-04 09:23:23 UTC (rev 187829)
@@ -52,6 +52,7 @@
     { "png", "image/png" },
     { "rss", "application/rss+xml" },
     { "svg", "image/svg+xml" },
+    { "swf", "application/x-shockwave-flash" },
     { "text", "text/plain" },
     { "txt", "text/plain" },
     { "xbm", "image/x-xbitmap" },
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to