Title: [187865] trunk/Source/WebKit2
- Revision
- 187865
- Author
- cdu...@apple.com
- Date
- 2015-08-04 10:12:19 -0700 (Tue, 04 Aug 2015)
Log Message
Unreviewed, rolling out r187812.
This is not safe
Reverted changeset:
"[WK2] Reserve Vector capacity in VectorArgumentCoder<false,
T, inlineCapacity>::decode()"
https://bugs.webkit.org/show_bug.cgi?id=147619
http://trac.webkit.org/changeset/187812
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (187864 => 187865)
--- trunk/Source/WebKit2/ChangeLog 2015-08-04 17:09:05 UTC (rev 187864)
+++ trunk/Source/WebKit2/ChangeLog 2015-08-04 17:12:19 UTC (rev 187865)
@@ -1,3 +1,16 @@
+2015-08-04 Chris Dumez <cdu...@apple.com>
+
+ Unreviewed, rolling out r187812.
+
+ This is not safe
+
+ Reverted changeset:
+
+ "[WK2] Reserve Vector capacity in VectorArgumentCoder<false,
+ T, inlineCapacity>::decode()"
+ https://bugs.webkit.org/show_bug.cgi?id=147619
+ http://trac.webkit.org/changeset/187812
+
2015-08-03 Chris Dumez <cdu...@apple.com>
[WK2] Reserve Vector capacity in VectorArgumentCoder<false, T, inlineCapacity>::decode()
Modified: trunk/Source/WebKit2/Platform/IPC/ArgumentCoders.h (187864 => 187865)
--- trunk/Source/WebKit2/Platform/IPC/ArgumentCoders.h 2015-08-04 17:09:05 UTC (rev 187864)
+++ trunk/Source/WebKit2/Platform/IPC/ArgumentCoders.h 2015-08-04 17:12:19 UTC (rev 187865)
@@ -164,15 +164,15 @@
return false;
Vector<T, inlineCapacity> tmp;
- tmp.reserveInitialCapacity(size);
for (size_t i = 0; i < size; ++i) {
T element;
if (!decoder.decode(element))
return false;
- tmp.uncheckedAppend(WTF::move(element));
+ tmp.append(WTF::move(element));
}
+ tmp.shrinkToFit();
vector.swap(tmp);
return true;
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
