Title: [187973] trunk/Source/WebKit2
- Revision
- 187973
- Author
- rn...@webkit.org
- Date
- 2015-08-05 12:21:25 -0700 (Wed, 05 Aug 2015)
Log Message
WebInspectorProxy should make WKWebView first responder
https://bugs.webkit.org/show_bug.cgi?id=147676
Reviewed by Timothy Hatcher.
Revert r181927 now that WKWebView forwards the first responder role to WKView as needed.
* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformBringToFront):
(WebKit::WebInspectorProxy::platformAttach):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (187972 => 187973)
--- trunk/Source/WebKit2/ChangeLog 2015-08-05 19:20:22 UTC (rev 187972)
+++ trunk/Source/WebKit2/ChangeLog 2015-08-05 19:21:25 UTC (rev 187973)
@@ -1,3 +1,16 @@
+2015-08-05 Ryosuke Niwa <rn...@webkit.org>
+
+ WebInspectorProxy should make WKWebView first responder
+ https://bugs.webkit.org/show_bug.cgi?id=147676
+
+ Reviewed by Timothy Hatcher.
+
+ Revert r181927 now that WKWebView forwards the first responder role to WKView as needed.
+
+ * UIProcess/mac/WebInspectorProxyMac.mm:
+ (WebKit::WebInspectorProxy::platformBringToFront):
+ (WebKit::WebInspectorProxy::platformAttach):
+
2015-08-04 Filip Pizlo <fpi...@apple.com>
Rename Mutex to DeprecatedMutex
Modified: trunk/Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm (187972 => 187973)
--- trunk/Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm 2015-08-05 19:20:22 UTC (rev 187972)
+++ trunk/Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm 2015-08-05 19:21:25 UTC (rev 187973)
@@ -587,7 +587,7 @@
// FIXME <rdar://problem/10937688>: this will not bring a background tab in Safari to the front, only its window.
[m_inspectorView.get().window makeKeyAndOrderFront:nil];
- [m_inspectorView.get().window makeFirstResponder:m_inspectorView->_page->wkView()];
+ [m_inspectorView.get().window makeFirstResponder:m_inspectorView.get()];
}
bool WebInspectorProxy::platformIsFront()
@@ -810,7 +810,7 @@
inspectedViewFrameDidChange(currentDimension);
[[inspectedView superview] addSubview:m_inspectorView.get() positioned:NSWindowBelow relativeTo:inspectedView];
- [m_inspectorView.get().window makeFirstResponder:m_inspectorView->_page->wkView()];
+ [m_inspectorView.get().window makeFirstResponder:m_inspectorView.get()];
}
void WebInspectorProxy::platformDetach()
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
