Title: [188122] trunk/Tools
- Revision
- 188122
- Author
- carlo...@webkit.org
- Date
- 2015-08-07 03:27:27 -0700 (Fri, 07 Aug 2015)
Log Message
[GTK] run-gtk-tests should not stop when a google test case fails
https://bugs.webkit.org/show_bug.cgi?id=147778
Reviewed by Philippe Normand.
For glib based tests we run the test runner with the -k option,
but for google tests we are aborting as soon as we find a failure.
* Scripts/run-gtk-tests:
(TestRunner._run_google_test_suite): Use a global return code that
is set to 1 when any test has failed.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (188121 => 188122)
--- trunk/Tools/ChangeLog 2015-08-07 09:51:20 UTC (rev 188121)
+++ trunk/Tools/ChangeLog 2015-08-07 10:27:27 UTC (rev 188122)
@@ -1,5 +1,19 @@
2015-08-07 Carlos Garcia Campos <cgar...@igalia.com>
+ [GTK] run-gtk-tests should not stop when a google test case fails
+ https://bugs.webkit.org/show_bug.cgi?id=147778
+
+ Reviewed by Philippe Normand.
+
+ For glib based tests we run the test runner with the -k option,
+ but for google tests we are aborting as soon as we find a failure.
+
+ * Scripts/run-gtk-tests:
+ (TestRunner._run_google_test_suite): Use a global return code that
+ is set to 1 when any test has failed.
+
+2015-08-07 Carlos Garcia Campos <cgar...@igalia.com>
+
[GStreamer] Do not automatically show PackageKit codec installation notifications
https://bugs.webkit.org/show_bug.cgi?id=135973
Modified: trunk/Tools/Scripts/run-gtk-tests (188121 => 188122)
--- trunk/Tools/Scripts/run-gtk-tests 2015-08-07 09:51:20 UTC (rev 188121)
+++ trunk/Tools/Scripts/run-gtk-tests 2015-08-07 10:27:27 UTC (rev 188122)
@@ -343,11 +343,11 @@
return self._run_test_command(test_command, self._options.timeout)
def _run_google_test_suite(self, test_program):
+ retcode = 0
for subtest in self._get_tests_from_google_test_suite(test_program):
- retcode = self._run_google_test(test_program, subtest)
- if retcode:
- return retcode
- return 0
+ if self._run_google_test(test_program, subtest):
+ retcode = 1
+ return retcode
def _run_test(self, test_program):
basedir = os.path.basename(os.path.dirname(test_program))
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
