Title: [188213] trunk
Revision
188213
Author
jcr...@apple.com
Date
2015-08-10 09:01:19 -0700 (Mon, 10 Aug 2015)

Log Message

AX: Address follow-up comments in bug 145684
https://bugs.webkit.org/show_bug.cgi?id=147817

Reviewed by Dean Jackson.

Minor cleanup and style updates requested by Dean.
Source/WebCore:

Updated Existing Test Expectations.

* Modules/mediacontrols/mediaControlsApple.css:
(video::-webkit-media-show-controls):
* Modules/mediacontrols/mediaControlsiOS.css:
(video::-webkit-media-show-controls):

LayoutTests:

* http/tests/contentextensions/text-track-blocked-expected.txt:
* media/video-controls-show-on-kb-or-ax-event.html:
* platform/mac/media/track/track-cue-rendering-horizontal-expected.txt:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (188212 => 188213)


--- trunk/LayoutTests/ChangeLog	2015-08-10 14:12:19 UTC (rev 188212)
+++ trunk/LayoutTests/ChangeLog	2015-08-10 16:01:19 UTC (rev 188213)
@@ -1,3 +1,16 @@
+2015-08-10  James Craig  <jcr...@apple.com>
+
+        AX: Address follow-up comments in bug 145684
+        https://bugs.webkit.org/show_bug.cgi?id=147817
+
+        Reviewed by Dean Jackson.
+
+        Minor cleanup and style updates requested by Dean.
+
+        * http/tests/contentextensions/text-track-blocked-expected.txt:
+        * media/video-controls-show-on-kb-or-ax-event.html:
+        * platform/mac/media/track/track-cue-rendering-horizontal-expected.txt:
+
 2015-08-07  Antti Koivisto  <an...@apple.com>
 
         Expand network cache tests to cover memory cache behavior

Modified: trunk/LayoutTests/http/tests/contentextensions/text-track-blocked-expected.txt (188212 => 188213)


--- trunk/LayoutTests/http/tests/contentextensions/text-track-blocked-expected.txt	2015-08-10 14:12:19 UTC (rev 188212)
+++ trunk/LayoutTests/http/tests/contentextensions/text-track-blocked-expected.txt	2015-08-10 16:01:19 UTC (rev 188213)
@@ -15,4 +15,4 @@
 layer at (8,26) size 320x240
   RenderFlexibleBox {DIV} at (0,0) size 320x240
 layer at (8,256) size 320x10
-  RenderButton {BUTTON} at (0,230) size 320x10 [bgcolor=#C0C0C0] [border: (2px outset #C0C0C0)]
+  RenderButton {BUTTON} at (0,230) size 320x10

Modified: trunk/LayoutTests/media/video-controls-show-on-kb-or-ax-event.html (188212 => 188213)


--- trunk/LayoutTests/media/video-controls-show-on-kb-or-ax-event.html	2015-08-10 14:12:19 UTC (rev 188212)
+++ trunk/LayoutTests/media/video-controls-show-on-kb-or-ax-event.html	2015-08-10 16:01:19 UTC (rev 188213)
@@ -27,9 +27,8 @@
             if (button) {
                 button.focus();
                 eventSender.keyDown(' '); // Use keyboard to press the selected button.
-            } else {
+            } else
                 result.innerHTML += 'FAIL: "Show Controls" button is not available.<br>';	
-            }
 
             // Verifies the toolbar is back in the DOM.
             var controls = root.firstChild.querySelector('[role="toolbar"]');

Modified: trunk/LayoutTests/platform/mac/media/track/track-cue-rendering-horizontal-expected.txt (188212 => 188213)


--- trunk/LayoutTests/platform/mac/media/track/track-cue-rendering-horizontal-expected.txt	2015-08-10 14:12:19 UTC (rev 188212)
+++ trunk/LayoutTests/platform/mac/media/track/track-cue-rendering-horizontal-expected.txt	2015-08-10 16:01:19 UTC (rev 188213)
@@ -61,4 +61,4 @@
         RenderText {#text} at (0,0) size 275x14
           text run at (0,0) width 275: "Cue 6: should be on top of bottom positioned cue 5."
 layer at (8,238) size 320x10
-  RenderButton {BUTTON} at (0,230) size 320x10 [bgcolor=#C0C0C0] [border: (2px outset #C0C0C0)]
+  RenderButton {BUTTON} at (0,230) size 320x10

Modified: trunk/Source/WebCore/ChangeLog (188212 => 188213)


--- trunk/Source/WebCore/ChangeLog	2015-08-10 14:12:19 UTC (rev 188212)
+++ trunk/Source/WebCore/ChangeLog	2015-08-10 16:01:19 UTC (rev 188213)
@@ -1,3 +1,18 @@
+2015-08-10  James Craig  <jcr...@apple.com>
+
+        AX: Address follow-up comments in bug 145684
+        https://bugs.webkit.org/show_bug.cgi?id=147817
+
+        Reviewed by Dean Jackson.
+
+        Minor cleanup and style updates requested by Dean.
+        Updated Existing Test Expectations.
+
+        * Modules/mediacontrols/mediaControlsApple.css:
+        (video::-webkit-media-show-controls):
+        * Modules/mediacontrols/mediaControlsiOS.css:
+        (video::-webkit-media-show-controls):
+
 2015-08-07  Antti Koivisto  <an...@apple.com>
 
         Expand network cache tests to cover memory cache behavior

Modified: trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.css (188212 => 188213)


--- trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.css	2015-08-10 14:12:19 UTC (rev 188212)
+++ trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.css	2015-08-10 16:01:19 UTC (rev 188213)
@@ -119,6 +119,8 @@
     width: 100%;
     height: 10px;
     opacity: 0;
+    border: 0;
+    background: none;
     -webkit-appearance: none;
 }
 

Modified: trunk/Source/WebCore/Modules/mediacontrols/mediaControlsiOS.css (188212 => 188213)


--- trunk/Source/WebCore/Modules/mediacontrols/mediaControlsiOS.css	2015-08-10 14:12:19 UTC (rev 188212)
+++ trunk/Source/WebCore/Modules/mediacontrols/mediaControlsiOS.css	2015-08-10 16:01:19 UTC (rev 188213)
@@ -145,6 +145,8 @@
     width: 100%;
     height: 10px;
     opacity: 0;
+    border: 0;
+    background: none;
     -webkit-appearance: none;
 }
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to