Title: [188261] trunk
Revision
188261
Author
[email protected]
Date
2015-08-11 10:52:00 -0700 (Tue, 11 Aug 2015)

Log Message

The 'length' property on interface objects should be configurable
https://bugs.webkit.org/show_bug.cgi?id=147858

Reviewed by Daniel Bates.

Source/WebCore:

Make the 'length' property configurable on interface objects to comply
with the Web IDL specification [1] and to align our behavior with
Firefox 38 and Chrome 44.

This behavior is also covered by the following W3C test suite:
http://w3c-test.org/dom/interfaces.html

[1] http://heycam.github.io/webidl/#es-interface-call (17 July 2015)

Test: fast/dom/length-property-configurable.html

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateConstructorHelperMethods):
Make the 'length' property configurable on interface objects.

* bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
(WebCore::JSTestActiveDOMObjectConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:
(WebCore::JSTestCustomConstructorWithNoInterfaceObjectConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
(WebCore::JSTestCustomNamedGetterConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestEventConstructor.cpp:
(WebCore::JSTestEventConstructorConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::JSTestEventTargetConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestException.cpp:
(WebCore::JSTestExceptionConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
(WebCore::JSTestGenerateIsReachableConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterfaceConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
(WebCore::JSTestMediaQueryListListenerConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::JSTestNamedConstructorConstructor::finishCreation):
(WebCore::JSTestNamedConstructorNamedConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestNode.cpp:
(WebCore::JSTestNodeConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestNondeterministic.cpp:
(WebCore::JSTestNondeterministicConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObjConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
(WebCore::JSTestOverloadedConstructorsConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore::JSTestTypedefsConstructor::finishCreation):
* bindings/scripts/test/JS/JSattribute.cpp:
(WebCore::JSattributeConstructor::finishCreation):
* bindings/scripts/test/JS/JSreadonly.cpp:
(WebCore::JSreadonlyConstructor::finishCreation):
Rebaseline bindings tests.

LayoutTests:

Add layout test to check that the 'length' property on interface
objects has the following attributes:
{ [[Writable]]: false, [[Enumerable]]: false, [[Configurable]]: true }

* fast/dom/length-property-configurable-expected.txt: Added.
* fast/dom/length-property-configurable.html: Added.

Modified Paths

Added Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (188260 => 188261)


--- trunk/LayoutTests/ChangeLog	2015-08-11 17:18:53 UTC (rev 188260)
+++ trunk/LayoutTests/ChangeLog	2015-08-11 17:52:00 UTC (rev 188261)
@@ -1,5 +1,19 @@
 2015-08-11  Chris Dumez  <[email protected]>
 
+        The 'length' property on interface objects should be configurable
+        https://bugs.webkit.org/show_bug.cgi?id=147858
+
+        Reviewed by Daniel Bates.
+
+        Add layout test to check that the 'length' property on interface
+        objects has the following attributes:
+        { [[Writable]]: false, [[Enumerable]]: false, [[Configurable]]: true }
+
+        * fast/dom/length-property-configurable-expected.txt: Added.
+        * fast/dom/length-property-configurable.html: Added.
+
+2015-08-11  Chris Dumez  <[email protected]>
+
         [WebIDL] All interface objects must have a property named "name"
         https://bugs.webkit.org/show_bug.cgi?id=147865
 

Added: trunk/LayoutTests/fast/dom/length-property-configurable-expected.txt (0 => 188261)


--- trunk/LayoutTests/fast/dom/length-property-configurable-expected.txt	                        (rev 0)
+++ trunk/LayoutTests/fast/dom/length-property-configurable-expected.txt	2015-08-11 17:52:00 UTC (rev 188261)
@@ -0,0 +1,39 @@
+The 'length' property on interfaces objects should have attributes { [[Writable]]: false, [[Enumerable]]: false, [[Configurable]]: true }.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+* Event
+PASS descriptor.writable is false
+PASS descriptor.enumerable is false
+PASS descriptor.configurable is true
+PASS descriptor.value is 1
+* Element
+PASS descriptor.writable is false
+PASS descriptor.enumerable is false
+PASS descriptor.configurable is true
+PASS descriptor.value is 0
+* Document
+PASS descriptor.writable is false
+PASS descriptor.enumerable is false
+PASS descriptor.configurable is true
+PASS descriptor.value is 0
+* Window
+PASS descriptor.writable is false
+PASS descriptor.enumerable is false
+PASS descriptor.configurable is true
+PASS descriptor.value is 0
+* HTMLOptionElement
+PASS descriptor.writable is false
+PASS descriptor.enumerable is false
+PASS descriptor.configurable is true
+PASS descriptor.value is 0
+* Option
+PASS descriptor.writable is false
+PASS descriptor.enumerable is false
+PASS descriptor.configurable is true
+PASS descriptor.value is 0
+PASS successfullyParsed is true
+
+TEST COMPLETE
+

Added: trunk/LayoutTests/fast/dom/length-property-configurable.html (0 => 188261)


--- trunk/LayoutTests/fast/dom/length-property-configurable.html	                        (rev 0)
+++ trunk/LayoutTests/fast/dom/length-property-configurable.html	2015-08-11 17:52:00 UTC (rev 188261)
@@ -0,0 +1,52 @@
+<!DOCTYPE html>
+<html>
+<body>
+<script src=""
+<script>
+description("The 'length' property on interfaces objects should have attributes { [[Writable]]: false, [[Enumerable]]: false, [[Configurable]]: true }.");
+
+debug("* Event");
+var descriptor = Object.getOwnPropertyDescriptor(Event, "length");
+shouldBeFalse("descriptor.writable");
+shouldBeFalse("descriptor.enumerable");
+shouldBeTrue("descriptor.configurable");
+shouldBe("descriptor.value", "1");
+
+debug("* Element");
+var descriptor = Object.getOwnPropertyDescriptor(Element, "length");
+shouldBeFalse("descriptor.writable");
+shouldBeFalse("descriptor.enumerable");
+shouldBeTrue("descriptor.configurable");
+shouldBe("descriptor.value", "0");
+
+debug("* Document");
+var descriptor = Object.getOwnPropertyDescriptor(Document, "length");
+shouldBeFalse("descriptor.writable");
+shouldBeFalse("descriptor.enumerable");
+shouldBeTrue("descriptor.configurable");
+shouldBe("descriptor.value", "0");
+
+debug("* Window");
+var descriptor = Object.getOwnPropertyDescriptor(Window, "length");
+shouldBeFalse("descriptor.writable");
+shouldBeFalse("descriptor.enumerable");
+shouldBeTrue("descriptor.configurable");
+shouldBe("descriptor.value", "0");
+
+debug("* HTMLOptionElement");
+var descriptor = Object.getOwnPropertyDescriptor(HTMLOptionElement, "length");
+shouldBeFalse("descriptor.writable");
+shouldBeFalse("descriptor.enumerable");
+shouldBeTrue("descriptor.configurable");
+shouldBe("descriptor.value", "0");
+
+debug("* Option");
+var descriptor = Object.getOwnPropertyDescriptor(Option, "length");
+shouldBeFalse("descriptor.writable");
+shouldBeFalse("descriptor.enumerable");
+shouldBeTrue("descriptor.configurable");
+shouldBe("descriptor.value", "0");
+</script>
+<script src=""
+</body>
+</html>

Modified: trunk/Source/WebCore/ChangeLog (188260 => 188261)


--- trunk/Source/WebCore/ChangeLog	2015-08-11 17:18:53 UTC (rev 188260)
+++ trunk/Source/WebCore/ChangeLog	2015-08-11 17:52:00 UTC (rev 188261)
@@ -1,3 +1,64 @@
+2015-08-11  Chris Dumez  <[email protected]>
+
+        The 'length' property on interface objects should be configurable
+        https://bugs.webkit.org/show_bug.cgi?id=147858
+
+        Reviewed by Daniel Bates.
+
+        Make the 'length' property configurable on interface objects to comply
+        with the Web IDL specification [1] and to align our behavior with
+        Firefox 38 and Chrome 44.
+
+        This behavior is also covered by the following W3C test suite:
+        http://w3c-test.org/dom/interfaces.html
+
+        [1] http://heycam.github.io/webidl/#es-interface-call (17 July 2015)
+
+        Test: fast/dom/length-property-configurable.html
+
+        * bindings/scripts/CodeGeneratorJS.pm:
+        (GenerateConstructorHelperMethods):
+        Make the 'length' property configurable on interface objects.
+
+        * bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
+        (WebCore::JSTestActiveDOMObjectConstructor::finishCreation):
+        * bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:
+        (WebCore::JSTestCustomConstructorWithNoInterfaceObjectConstructor::finishCreation):
+        * bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
+        (WebCore::JSTestCustomNamedGetterConstructor::finishCreation):
+        * bindings/scripts/test/JS/JSTestEventConstructor.cpp:
+        (WebCore::JSTestEventConstructorConstructor::finishCreation):
+        * bindings/scripts/test/JS/JSTestEventTarget.cpp:
+        (WebCore::JSTestEventTargetConstructor::finishCreation):
+        * bindings/scripts/test/JS/JSTestException.cpp:
+        (WebCore::JSTestExceptionConstructor::finishCreation):
+        * bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
+        (WebCore::JSTestGenerateIsReachableConstructor::finishCreation):
+        * bindings/scripts/test/JS/JSTestInterface.cpp:
+        (WebCore::JSTestInterfaceConstructor::finishCreation):
+        * bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
+        (WebCore::JSTestMediaQueryListListenerConstructor::finishCreation):
+        * bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
+        (WebCore::JSTestNamedConstructorConstructor::finishCreation):
+        (WebCore::JSTestNamedConstructorNamedConstructor::finishCreation):
+        * bindings/scripts/test/JS/JSTestNode.cpp:
+        (WebCore::JSTestNodeConstructor::finishCreation):
+        * bindings/scripts/test/JS/JSTestNondeterministic.cpp:
+        (WebCore::JSTestNondeterministicConstructor::finishCreation):
+        * bindings/scripts/test/JS/JSTestObj.cpp:
+        (WebCore::JSTestObjConstructor::finishCreation):
+        * bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
+        (WebCore::JSTestOverloadedConstructorsConstructor::finishCreation):
+        * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
+        (WebCore::JSTestSerializedScriptValueInterfaceConstructor::finishCreation):
+        * bindings/scripts/test/JS/JSTestTypedefs.cpp:
+        (WebCore::JSTestTypedefsConstructor::finishCreation):
+        * bindings/scripts/test/JS/JSattribute.cpp:
+        (WebCore::JSattributeConstructor::finishCreation):
+        * bindings/scripts/test/JS/JSreadonly.cpp:
+        (WebCore::JSreadonlyConstructor::finishCreation):
+        Rebaseline bindings tests.
+
 2015-08-11  Per Arne Vollan  <[email protected]>
 
         [Win] Popup menus have incorrect placement when device scale factor != 1.

Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (188260 => 188261)


--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2015-08-11 17:18:53 UTC (rev 188260)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2015-08-11 17:52:00 UTC (rev 188261)
@@ -4795,7 +4795,7 @@
     push(@$outputArray, "    putDirect(vm, vm.propertyNames->name, jsNontrivialString(&vm, String(ASCIILiteral(\"$visibleInterfaceName\"))), ReadOnly | DontEnum);\n");
 
     if (defined $leastConstructorLength) {
-        push(@$outputArray, "    putDirect(vm, vm.propertyNames->length, jsNumber(${leastConstructorLength}), ReadOnly | DontDelete | DontEnum);\n");
+        push(@$outputArray, "    putDirect(vm, vm.propertyNames->length, jsNumber(${leastConstructorLength}), ReadOnly | DontEnum);\n");
     }
 
     if (ConstructorHasProperties($interface)) {

Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestActiveDOMObject.cpp (188260 => 188261)


--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestActiveDOMObject.cpp	2015-08-11 17:18:53 UTC (rev 188260)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestActiveDOMObject.cpp	2015-08-11 17:52:00 UTC (rev 188261)
@@ -119,7 +119,7 @@
     ASSERT(inherits(info()));
     putDirect(vm, vm.propertyNames->prototype, JSTestActiveDOMObject::getPrototype(vm, globalObject), DontDelete | ReadOnly | DontEnum);
     putDirect(vm, vm.propertyNames->name, jsNontrivialString(&vm, String(ASCIILiteral("TestActiveDOMObject"))), ReadOnly | DontEnum);
-    putDirect(vm, vm.propertyNames->length, jsNumber(0), ReadOnly | DontDelete | DontEnum);
+    putDirect(vm, vm.propertyNames->length, jsNumber(0), ReadOnly | DontEnum);
 }
 
 /* Hash table for prototype */

Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp (188260 => 188261)


--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp	2015-08-11 17:18:53 UTC (rev 188260)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp	2015-08-11 17:52:00 UTC (rev 188261)
@@ -93,7 +93,7 @@
     ASSERT(inherits(info()));
     putDirect(vm, vm.propertyNames->prototype, JSTestCustomConstructorWithNoInterfaceObject::getPrototype(vm, globalObject), DontDelete | ReadOnly | DontEnum);
     putDirect(vm, vm.propertyNames->name, jsNontrivialString(&vm, String(ASCIILiteral("TestCustomConstructorWithNoInterfaceObject"))), ReadOnly | DontEnum);
-    putDirect(vm, vm.propertyNames->length, jsNumber(0), ReadOnly | DontDelete | DontEnum);
+    putDirect(vm, vm.propertyNames->length, jsNumber(0), ReadOnly | DontEnum);
 }
 
 ConstructType JSTestCustomConstructorWithNoInterfaceObjectConstructor::getConstructData(JSCell*, ConstructData& constructData)

Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp (188260 => 188261)


--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp	2015-08-11 17:18:53 UTC (rev 188260)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp	2015-08-11 17:52:00 UTC (rev 188261)
@@ -113,7 +113,7 @@
     ASSERT(inherits(info()));
     putDirect(vm, vm.propertyNames->prototype, JSTestCustomNamedGetter::getPrototype(vm, globalObject), DontDelete | ReadOnly | DontEnum);
     putDirect(vm, vm.propertyNames->name, jsNontrivialString(&vm, String(ASCIILiteral("TestCustomNamedGetter"))), ReadOnly | DontEnum);
-    putDirect(vm, vm.propertyNames->length, jsNumber(0), ReadOnly | DontDelete | DontEnum);
+    putDirect(vm, vm.propertyNames->length, jsNumber(0), ReadOnly | DontEnum);
 }
 
 /* Hash table for prototype */

Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventConstructor.cpp (188260 => 188261)


--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventConstructor.cpp	2015-08-11 17:18:53 UTC (rev 188260)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventConstructor.cpp	2015-08-11 17:52:00 UTC (rev 188261)
@@ -140,7 +140,7 @@
     ASSERT(inherits(info()));
     putDirect(vm, vm.propertyNames->prototype, JSTestEventConstructor::getPrototype(vm, globalObject), DontDelete | ReadOnly | DontEnum);
     putDirect(vm, vm.propertyNames->name, jsNontrivialString(&vm, String(ASCIILiteral("TestEventConstructor"))), ReadOnly | DontEnum);
-    putDirect(vm, vm.propertyNames->length, jsNumber(1), ReadOnly | DontDelete | DontEnum);
+    putDirect(vm, vm.propertyNames->length, jsNumber(1), ReadOnly | DontEnum);
 }
 
 ConstructType JSTestEventConstructorConstructor::getConstructData(JSCell*, ConstructData& constructData)

Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventTarget.cpp (188260 => 188261)


--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventTarget.cpp	2015-08-11 17:18:53 UTC (rev 188260)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventTarget.cpp	2015-08-11 17:52:00 UTC (rev 188261)
@@ -122,7 +122,7 @@
     ASSERT(inherits(info()));
     putDirect(vm, vm.propertyNames->prototype, JSTestEventTarget::getPrototype(vm, globalObject), DontDelete | ReadOnly | DontEnum);
     putDirect(vm, vm.propertyNames->name, jsNontrivialString(&vm, String(ASCIILiteral("TestEventTarget"))), ReadOnly | DontEnum);
-    putDirect(vm, vm.propertyNames->length, jsNumber(0), ReadOnly | DontDelete | DontEnum);
+    putDirect(vm, vm.propertyNames->length, jsNumber(0), ReadOnly | DontEnum);
 }
 
 /* Hash table for prototype */

Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestException.cpp (188260 => 188261)


--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestException.cpp	2015-08-11 17:18:53 UTC (rev 188260)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestException.cpp	2015-08-11 17:52:00 UTC (rev 188261)
@@ -110,7 +110,7 @@
     ASSERT(inherits(info()));
     putDirect(vm, vm.propertyNames->prototype, JSTestException::getPrototype(vm, globalObject), DontDelete | ReadOnly | DontEnum);
     putDirect(vm, vm.propertyNames->name, jsNontrivialString(&vm, String(ASCIILiteral("TestException"))), ReadOnly | DontEnum);
-    putDirect(vm, vm.propertyNames->length, jsNumber(0), ReadOnly | DontDelete | DontEnum);
+    putDirect(vm, vm.propertyNames->length, jsNumber(0), ReadOnly | DontEnum);
 }
 
 /* Hash table for prototype */

Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp (188260 => 188261)


--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp	2015-08-11 17:18:53 UTC (rev 188260)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp	2015-08-11 17:52:00 UTC (rev 188261)
@@ -92,7 +92,7 @@
     ASSERT(inherits(info()));
     putDirect(vm, vm.propertyNames->prototype, JSTestGenerateIsReachable::getPrototype(vm, globalObject), DontDelete | ReadOnly | DontEnum);
     putDirect(vm, vm.propertyNames->name, jsNontrivialString(&vm, String(ASCIILiteral("TestGenerateIsReachable"))), ReadOnly | DontEnum);
-    putDirect(vm, vm.propertyNames->length, jsNumber(0), ReadOnly | DontDelete | DontEnum);
+    putDirect(vm, vm.propertyNames->length, jsNumber(0), ReadOnly | DontEnum);
 }
 
 /* Hash table for prototype */

Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp (188260 => 188261)


--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp	2015-08-11 17:18:53 UTC (rev 188260)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp	2015-08-11 17:52:00 UTC (rev 188261)
@@ -302,7 +302,7 @@
     ASSERT(inherits(info()));
     putDirect(vm, vm.propertyNames->prototype, JSTestInterface::getPrototype(vm, globalObject), DontDelete | ReadOnly | DontEnum);
     putDirect(vm, vm.propertyNames->name, jsNontrivialString(&vm, String(ASCIILiteral("TestInterface"))), ReadOnly | DontEnum);
-    putDirect(vm, vm.propertyNames->length, jsNumber(1), ReadOnly | DontDelete | DontEnum);
+    putDirect(vm, vm.propertyNames->length, jsNumber(1), ReadOnly | DontEnum);
     reifyStaticProperties(vm, JSTestInterfaceConstructorTableValues, *this);
 }
 

Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp (188260 => 188261)


--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp	2015-08-11 17:18:53 UTC (rev 188260)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp	2015-08-11 17:52:00 UTC (rev 188261)
@@ -99,7 +99,7 @@
     ASSERT(inherits(info()));
     putDirect(vm, vm.propertyNames->prototype, JSTestMediaQueryListListener::getPrototype(vm, globalObject), DontDelete | ReadOnly | DontEnum);
     putDirect(vm, vm.propertyNames->name, jsNontrivialString(&vm, String(ASCIILiteral("TestMediaQueryListListener"))), ReadOnly | DontEnum);
-    putDirect(vm, vm.propertyNames->length, jsNumber(0), ReadOnly | DontDelete | DontEnum);
+    putDirect(vm, vm.propertyNames->length, jsNumber(0), ReadOnly | DontEnum);
 }
 
 /* Hash table for prototype */

Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNamedConstructor.cpp (188260 => 188261)


--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNamedConstructor.cpp	2015-08-11 17:18:53 UTC (rev 188260)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNamedConstructor.cpp	2015-08-11 17:52:00 UTC (rev 188261)
@@ -120,7 +120,7 @@
     ASSERT(inherits(info()));
     putDirect(vm, vm.propertyNames->prototype, JSTestNamedConstructor::getPrototype(vm, globalObject), DontDelete | ReadOnly | DontEnum);
     putDirect(vm, vm.propertyNames->name, jsNontrivialString(&vm, String(ASCIILiteral("TestNamedConstructor"))), ReadOnly | DontEnum);
-    putDirect(vm, vm.propertyNames->length, jsNumber(0), ReadOnly | DontDelete | DontEnum);
+    putDirect(vm, vm.propertyNames->length, jsNumber(0), ReadOnly | DontEnum);
 }
 
 EncodedJSValue JSC_HOST_CALL JSTestNamedConstructorNamedConstructor::constructJSTestNamedConstructor(ExecState* exec)
@@ -159,7 +159,7 @@
     ASSERT(inherits(info()));
     putDirect(vm, vm.propertyNames->prototype, JSTestNamedConstructor::getPrototype(vm, globalObject), DontDelete | ReadOnly | DontEnum);
     putDirect(vm, vm.propertyNames->name, jsNontrivialString(&vm, String(ASCIILiteral("Audio"))), ReadOnly | DontEnum);
-    putDirect(vm, vm.propertyNames->length, jsNumber(0), ReadOnly | DontDelete | DontEnum);
+    putDirect(vm, vm.propertyNames->length, jsNumber(0), ReadOnly | DontEnum);
 }
 
 ConstructType JSTestNamedConstructorNamedConstructor::getConstructData(JSCell*, ConstructData& constructData)

Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNode.cpp (188260 => 188261)


--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNode.cpp	2015-08-11 17:18:53 UTC (rev 188260)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNode.cpp	2015-08-11 17:52:00 UTC (rev 188261)
@@ -104,7 +104,7 @@
     ASSERT(inherits(info()));
     putDirect(vm, vm.propertyNames->prototype, JSTestNode::getPrototype(vm, globalObject), DontDelete | ReadOnly | DontEnum);
     putDirect(vm, vm.propertyNames->name, jsNontrivialString(&vm, String(ASCIILiteral("TestNode"))), ReadOnly | DontEnum);
-    putDirect(vm, vm.propertyNames->length, jsNumber(0), ReadOnly | DontDelete | DontEnum);
+    putDirect(vm, vm.propertyNames->length, jsNumber(0), ReadOnly | DontEnum);
 }
 
 ConstructType JSTestNodeConstructor::getConstructData(JSCell*, ConstructData& constructData)

Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNondeterministic.cpp (188260 => 188261)


--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNondeterministic.cpp	2015-08-11 17:18:53 UTC (rev 188260)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNondeterministic.cpp	2015-08-11 17:52:00 UTC (rev 188261)
@@ -116,7 +116,7 @@
     ASSERT(inherits(info()));
     putDirect(vm, vm.propertyNames->prototype, JSTestNondeterministic::getPrototype(vm, globalObject), DontDelete | ReadOnly | DontEnum);
     putDirect(vm, vm.propertyNames->name, jsNontrivialString(&vm, String(ASCIILiteral("TestNondeterministic"))), ReadOnly | DontEnum);
-    putDirect(vm, vm.propertyNames->length, jsNumber(0), ReadOnly | DontDelete | DontEnum);
+    putDirect(vm, vm.propertyNames->length, jsNumber(0), ReadOnly | DontEnum);
 }
 
 /* Hash table for prototype */

Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp (188260 => 188261)


--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp	2015-08-11 17:18:53 UTC (rev 188260)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp	2015-08-11 17:52:00 UTC (rev 188261)
@@ -476,7 +476,7 @@
     ASSERT(inherits(info()));
     putDirect(vm, vm.propertyNames->prototype, JSTestObj::getPrototype(vm, globalObject), DontDelete | ReadOnly | DontEnum);
     putDirect(vm, vm.propertyNames->name, jsNontrivialString(&vm, String(ASCIILiteral("TestObject"))), ReadOnly | DontEnum);
-    putDirect(vm, vm.propertyNames->length, jsNumber(1), ReadOnly | DontDelete | DontEnum);
+    putDirect(vm, vm.propertyNames->length, jsNumber(1), ReadOnly | DontEnum);
     reifyStaticProperties(vm, JSTestObjConstructorTableValues, *this);
 }
 

Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp (188260 => 188261)


--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp	2015-08-11 17:18:53 UTC (rev 188260)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp	2015-08-11 17:52:00 UTC (rev 188261)
@@ -180,7 +180,7 @@
     ASSERT(inherits(info()));
     putDirect(vm, vm.propertyNames->prototype, JSTestOverloadedConstructors::getPrototype(vm, globalObject), DontDelete | ReadOnly | DontEnum);
     putDirect(vm, vm.propertyNames->name, jsNontrivialString(&vm, String(ASCIILiteral("TestOverloadedConstructors"))), ReadOnly | DontEnum);
-    putDirect(vm, vm.propertyNames->length, jsNumber(1), ReadOnly | DontDelete | DontEnum);
+    putDirect(vm, vm.propertyNames->length, jsNumber(1), ReadOnly | DontEnum);
 }
 
 ConstructType JSTestOverloadedConstructorsConstructor::getConstructData(JSCell*, ConstructData& constructData)

Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp (188260 => 188261)


--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp	2015-08-11 17:18:53 UTC (rev 188260)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp	2015-08-11 17:52:00 UTC (rev 188261)
@@ -107,7 +107,7 @@
     ASSERT(inherits(info()));
     putDirect(vm, vm.propertyNames->prototype, JSTestSerializedScriptValueInterface::getPrototype(vm, globalObject), DontDelete | ReadOnly | DontEnum);
     putDirect(vm, vm.propertyNames->name, jsNontrivialString(&vm, String(ASCIILiteral("TestSerializedScriptValueInterface"))), ReadOnly | DontEnum);
-    putDirect(vm, vm.propertyNames->length, jsNumber(0), ReadOnly | DontDelete | DontEnum);
+    putDirect(vm, vm.propertyNames->length, jsNumber(0), ReadOnly | DontEnum);
 }
 
 /* Hash table for prototype */

Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestTypedefs.cpp (188260 => 188261)


--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestTypedefs.cpp	2015-08-11 17:18:53 UTC (rev 188260)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestTypedefs.cpp	2015-08-11 17:52:00 UTC (rev 188261)
@@ -172,7 +172,7 @@
     ASSERT(inherits(info()));
     putDirect(vm, vm.propertyNames->prototype, JSTestTypedefs::getPrototype(vm, globalObject), DontDelete | ReadOnly | DontEnum);
     putDirect(vm, vm.propertyNames->name, jsNontrivialString(&vm, String(ASCIILiteral("TestTypedefs"))), ReadOnly | DontEnum);
-    putDirect(vm, vm.propertyNames->length, jsNumber(2), ReadOnly | DontDelete | DontEnum);
+    putDirect(vm, vm.propertyNames->length, jsNumber(2), ReadOnly | DontEnum);
     reifyStaticProperties(vm, JSTestTypedefsConstructorTableValues, *this);
 }
 

Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSattribute.cpp (188260 => 188261)


--- trunk/Source/WebCore/bindings/scripts/test/JS/JSattribute.cpp	2015-08-11 17:18:53 UTC (rev 188260)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSattribute.cpp	2015-08-11 17:52:00 UTC (rev 188261)
@@ -96,7 +96,7 @@
     ASSERT(inherits(info()));
     putDirect(vm, vm.propertyNames->prototype, JSattribute::getPrototype(vm, globalObject), DontDelete | ReadOnly | DontEnum);
     putDirect(vm, vm.propertyNames->name, jsNontrivialString(&vm, String(ASCIILiteral("attribute"))), ReadOnly | DontEnum);
-    putDirect(vm, vm.propertyNames->length, jsNumber(0), ReadOnly | DontDelete | DontEnum);
+    putDirect(vm, vm.propertyNames->length, jsNumber(0), ReadOnly | DontEnum);
 }
 
 /* Hash table for prototype */

Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSreadonly.cpp (188260 => 188261)


--- trunk/Source/WebCore/bindings/scripts/test/JS/JSreadonly.cpp	2015-08-11 17:18:53 UTC (rev 188260)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSreadonly.cpp	2015-08-11 17:52:00 UTC (rev 188261)
@@ -92,7 +92,7 @@
     ASSERT(inherits(info()));
     putDirect(vm, vm.propertyNames->prototype, JSreadonly::getPrototype(vm, globalObject), DontDelete | ReadOnly | DontEnum);
     putDirect(vm, vm.propertyNames->name, jsNontrivialString(&vm, String(ASCIILiteral("readonly"))), ReadOnly | DontEnum);
-    putDirect(vm, vm.propertyNames->length, jsNumber(0), ReadOnly | DontDelete | DontEnum);
+    putDirect(vm, vm.propertyNames->length, jsNumber(0), ReadOnly | DontEnum);
 }
 
 /* Hash table for prototype */
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to