Title: [188330] trunk/Source/WebInspectorUI
- Revision
- 188330
- Author
- [email protected]
- Date
- 2015-08-11 23:05:08 -0700 (Tue, 11 Aug 2015)
Log Message
Web Inspector: TimelineView data not cleared when recording is reset
https://bugs.webkit.org/show_bug.cgi?id=147916
Reviewed by Timothy Hatcher.
Each derived timeline view maintains a separate array of timeline records. These weren't
cleared on reset, so switching to a timeline view after clearing the recording caused
the view to populate its tree outline.
* UserInterface/Views/LayoutTimelineView.js:
(WebInspector.LayoutTimelineView.set columns):
(WebInspector.LayoutTimelineView):
* UserInterface/Views/NetworkTimelineView.js:
(WebInspector.NetworkTimelineView.set columns):
(WebInspector.NetworkTimelineView):
* UserInterface/Views/OverviewTimelineView.js:
(WebInspector.OverviewTimelineView.prototype.reset):
(WebInspector.OverviewTimelineView.prototype._processPendingRepresentedObjects):
* UserInterface/Views/RenderingFrameTimelineView.js:
(WebInspector.RenderingFrameTimelineView.prototype.reset):
* UserInterface/Views/ScriptTimelineView.js:
(WebInspector.ScriptTimelineView.prototype.reset):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (188329 => 188330)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-08-12 05:56:20 UTC (rev 188329)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-08-12 06:05:08 UTC (rev 188330)
@@ -1,5 +1,30 @@
2015-08-11 Matt Baker <[email protected]>
+ Web Inspector: TimelineView data not cleared when recording is reset
+ https://bugs.webkit.org/show_bug.cgi?id=147916
+
+ Reviewed by Timothy Hatcher.
+
+ Each derived timeline view maintains a separate array of timeline records. These weren't
+ cleared on reset, so switching to a timeline view after clearing the recording caused
+ the view to populate its tree outline.
+
+ * UserInterface/Views/LayoutTimelineView.js:
+ (WebInspector.LayoutTimelineView.set columns):
+ (WebInspector.LayoutTimelineView):
+ * UserInterface/Views/NetworkTimelineView.js:
+ (WebInspector.NetworkTimelineView.set columns):
+ (WebInspector.NetworkTimelineView):
+ * UserInterface/Views/OverviewTimelineView.js:
+ (WebInspector.OverviewTimelineView.prototype.reset):
+ (WebInspector.OverviewTimelineView.prototype._processPendingRepresentedObjects):
+ * UserInterface/Views/RenderingFrameTimelineView.js:
+ (WebInspector.RenderingFrameTimelineView.prototype.reset):
+ * UserInterface/Views/ScriptTimelineView.js:
+ (WebInspector.ScriptTimelineView.prototype.reset):
+
+2015-08-11 Matt Baker <[email protected]>
+
Web Inspector: Dragging a timeline ruler handle when both handles clamped is broken
https://bugs.webkit.org/show_bug.cgi?id=147912
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/LayoutTimelineView.js (188329 => 188330)
--- trunk/Source/WebInspectorUI/UserInterface/Views/LayoutTimelineView.js 2015-08-12 05:56:20 UTC (rev 188329)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/LayoutTimelineView.js 2015-08-12 06:05:08 UTC (rev 188330)
@@ -154,6 +154,8 @@
this._hideHighlightIfNeeded();
this._dataGrid.reset();
+
+ this._pendingRecords = [];
}
// Protected
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTimelineView.js (188329 => 188330)
--- trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTimelineView.js 2015-08-12 05:56:20 UTC (rev 188329)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTimelineView.js 2015-08-12 06:05:08 UTC (rev 188330)
@@ -148,6 +148,8 @@
super.reset();
this._dataGrid.reset();
+
+ this._pendingRecords = [];
}
// Protected
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/OverviewTimelineView.js (188329 => 188330)
--- trunk/Source/WebInspectorUI/UserInterface/Views/OverviewTimelineView.js 2015-08-12 05:56:20 UTC (rev 188329)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/OverviewTimelineView.js 2015-08-12 06:05:08 UTC (rev 188330)
@@ -142,6 +142,13 @@
return pathComponents;
}
+ reset()
+ {
+ super.reset();
+
+ this._pendingRepresentedObjects = [];
+ }
+
// Protected
treeElementPathComponentSelected(event)
@@ -306,7 +313,7 @@
_processPendingRepresentedObjects()
{
- if (!this._pendingRepresentedObjects || !this._pendingRepresentedObjects.length)
+ if (!this._pendingRepresentedObjects.length)
return;
for (var representedObject of this._pendingRepresentedObjects) {
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/RenderingFrameTimelineView.js (188329 => 188330)
--- trunk/Source/WebInspectorUI/UserInterface/Views/RenderingFrameTimelineView.js 2015-08-12 05:56:20 UTC (rev 188329)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/RenderingFrameTimelineView.js 2015-08-12 06:05:08 UTC (rev 188330)
@@ -189,6 +189,8 @@
super.reset();
this._dataGrid.reset();
+
+ this._pendingRecords = [];
}
// Protected
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ScriptTimelineView.js (188329 => 188330)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ScriptTimelineView.js 2015-08-12 05:56:20 UTC (rev 188329)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ScriptTimelineView.js 2015-08-12 06:05:08 UTC (rev 188330)
@@ -162,6 +162,8 @@
super.reset();
this._dataGrid.reset();
+
+ this._pendingRecords = [];
}
// Protected
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
