Title: [188382] trunk/Source/WebInspectorUI
Revision
188382
Author
[email protected]
Date
2015-08-13 04:49:43 -0700 (Thu, 13 Aug 2015)

Log Message

REGRESSION (r188325): Web Inspector: Fix vertical spacing in CodeMirror
https://bugs.webkit.org/show_bug.cgi?id=147971

r188325 inceased line-height by 2px. Remove top and bottom 1px padding
to compensate for line-height changes.

In the feature we may highlight the backgroud of text tokens (e.g. for the
heatmap profiler) so we would want to get rid of the gaps between the lines
(caused by the paddind) regardless of this regression.

Reviewed by Timothy Hatcher.

* UserInterface/Views/CodeMirrorOverrides.css:
(.CodeMirror pre):

Modified Paths

Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (188381 => 188382)


--- trunk/Source/WebInspectorUI/ChangeLog	2015-08-13 07:03:02 UTC (rev 188381)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-08-13 11:49:43 UTC (rev 188382)
@@ -1,3 +1,20 @@
+2015-08-13  Nikita Vasilyev  <[email protected]>
+
+        REGRESSION (r188325): Web Inspector: Fix vertical spacing in CodeMirror
+        https://bugs.webkit.org/show_bug.cgi?id=147971
+
+        r188325 inceased line-height by 2px. Remove top and bottom 1px padding
+        to compensate for line-height changes.
+
+        In the feature we may highlight the backgroud of text tokens (e.g. for the
+        heatmap profiler) so we would want to get rid of the gaps between the lines
+        (caused by the paddind) regardless of this regression.
+
+        Reviewed by Timothy Hatcher.
+
+        * UserInterface/Views/CodeMirrorOverrides.css:
+        (.CodeMirror pre):
+
 2015-08-12  Joseph Pecoraro  <[email protected]>
 
         Web Inspector: Sometimes CSS resources don't update after editing via Styles panel

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CodeMirrorOverrides.css (188381 => 188382)


--- trunk/Source/WebInspectorUI/UserInterface/Views/CodeMirrorOverrides.css	2015-08-13 07:03:02 UTC (rev 188381)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CodeMirrorOverrides.css	2015-08-13 11:49:43 UTC (rev 188382)
@@ -38,7 +38,7 @@
 }
 
 .CodeMirror pre {
-    padding: 1px 3px 1px 7px;
+    padding: 0 3px 0 7px;
 }
 
 .CodeMirror .CodeMirror-selected {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to