Title: [188426] trunk/LayoutTests
Revision
188426
Author
joep...@webkit.org
Date
2015-08-13 18:29:48 -0700 (Thu, 13 Aug 2015)

Log Message

Web Inspector: Reduce flakiness of inspector/indexeddb/requestDatabaseNames
https://bugs.webkit.org/show_bug.cgi?id=148008

Reviewed by Timothy Hatcher.

* inspector/indexeddb/requestDatabaseNames.html:
Follow-up fix to reduce flakiness in the test caused by other tests
creating IndexedDB databases.

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (188425 => 188426)


--- trunk/LayoutTests/ChangeLog	2015-08-14 01:06:05 UTC (rev 188425)
+++ trunk/LayoutTests/ChangeLog	2015-08-14 01:29:48 UTC (rev 188426)
@@ -1,3 +1,14 @@
+2015-08-13  Joseph Pecoraro  <pecor...@apple.com>
+
+        Web Inspector: Reduce flakiness of inspector/indexeddb/requestDatabaseNames
+        https://bugs.webkit.org/show_bug.cgi?id=148008
+
+        Reviewed by Timothy Hatcher.
+
+        * inspector/indexeddb/requestDatabaseNames.html:
+        Follow-up fix to reduce flakiness in the test caused by other tests
+        creating IndexedDB databases.
+
 2015-08-13  Jon Honeycutt  <jhoneyc...@apple.com>
 
         iOS test gardening.

Modified: trunk/LayoutTests/inspector/indexeddb/requestDatabaseNames.html (188425 => 188426)


--- trunk/LayoutTests/inspector/indexeddb/requestDatabaseNames.html	2015-08-14 01:06:05 UTC (rev 188425)
+++ trunk/LayoutTests/inspector/indexeddb/requestDatabaseNames.html	2015-08-14 01:29:48 UTC (rev 188426)
@@ -11,12 +11,28 @@
     });
 }
 
+function deleteDatabaseNames(names)
+{
+    for (let name of names)
+        window.indexedDB.deleteDatabase(name);
+}
+
 function test()
 {
     var steps = [
         {
             action: function() {
+                // FIXME: Remove any existing IndexedDB databases that might exist to workaround:
+                // <https://webkit.org/b/148006> Each test should run with its own clean data store
                 IndexedDBAgent.requestDatabaseNames(WebInspector.frameResourceManager.mainFrame.securityOrigin, function(error, names) {
+                    InspectorTest.evaluateInPage("deleteDatabaseNames(" + JSON.stringify(names) + ")");
+                    next();
+                });
+            }
+        },
+        {
+            action: function() {
+                IndexedDBAgent.requestDatabaseNames(WebInspector.frameResourceManager.mainFrame.securityOrigin, function(error, names) {
                     InspectorTest.expectNoError(error);
                     InspectorTest.expectThat(names.length === 0, "No IndexedDB databases should exist initially");
                     InspectorTest.evaluateInPage("createDatabase('Database1')");
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to