Title: [188461] releases/WebKitGTK/webkit-2.10/Source/_javascript_Core
- Revision
- 188461
- Author
- [email protected]
- Date
- 2015-08-14 04:30:18 -0700 (Fri, 14 Aug 2015)
Log Message
Merge r188397 - RegExpCache::finalize should not delete code
https://bugs.webkit.org/show_bug.cgi?id=147987
Reviewed by Mark Lam.
The RegExp object already knows how to delete its own code in its
destructor. Our job is just to clear our stale pointer.
* runtime/RegExpCache.cpp:
(JSC::RegExpCache::finalize):
(JSC::RegExpCache::addToStrongCache):
Modified Paths
Diff
Modified: releases/WebKitGTK/webkit-2.10/Source/_javascript_Core/ChangeLog (188460 => 188461)
--- releases/WebKitGTK/webkit-2.10/Source/_javascript_Core/ChangeLog 2015-08-14 11:28:47 UTC (rev 188460)
+++ releases/WebKitGTK/webkit-2.10/Source/_javascript_Core/ChangeLog 2015-08-14 11:30:18 UTC (rev 188461)
@@ -1,5 +1,19 @@
2015-08-13 Geoffrey Garen <[email protected]>
+ RegExpCache::finalize should not delete code
+ https://bugs.webkit.org/show_bug.cgi?id=147987
+
+ Reviewed by Mark Lam.
+
+ The RegExp object already knows how to delete its own code in its
+ destructor. Our job is just to clear our stale pointer.
+
+ * runtime/RegExpCache.cpp:
+ (JSC::RegExpCache::finalize):
+ (JSC::RegExpCache::addToStrongCache):
+
+2015-08-13 Geoffrey Garen <[email protected]>
+
Standardize on the phrase "delete code"
https://bugs.webkit.org/show_bug.cgi?id=147984
Modified: releases/WebKitGTK/webkit-2.10/Source/_javascript_Core/runtime/RegExpCache.cpp (188460 => 188461)
--- releases/WebKitGTK/webkit-2.10/Source/_javascript_Core/runtime/RegExpCache.cpp 2015-08-14 11:28:47 UTC (rev 188460)
+++ releases/WebKitGTK/webkit-2.10/Source/_javascript_Core/runtime/RegExpCache.cpp 2015-08-14 11:30:18 UTC (rev 188461)
@@ -60,7 +60,6 @@
{
RegExp* regExp = static_cast<RegExp*>(handle.get().asCell());
weakRemove(m_weakCache, regExp->key(), regExp);
- regExp->deleteCode();
}
void RegExpCache::addToStrongCache(RegExp* regExp)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
