Title: [188525] trunk/Source/WebKit/win
- Revision
- 188525
- Author
- [email protected]
- Date
- 2015-08-17 10:41:44 -0700 (Mon, 17 Aug 2015)
Log Message
[Win] Cleanups to PluginView::handleMouseEvent().
https://bugs.webkit.org/show_bug.cgi?id=148024
Patch by Sungmann Cho <[email protected]> on 2015-08-17
Reviewed by Alex Christensen.
1. Replace the raw values identifying specific mouse buttons with
WebCore::MouseButton enum values.
2. Reindent if and switch statements.
* Plugins/PluginViewWin.cpp:
(WebCore::PluginView::handleMouseEvent):
Modified Paths
Diff
Modified: trunk/Source/WebKit/win/ChangeLog (188524 => 188525)
--- trunk/Source/WebKit/win/ChangeLog 2015-08-17 17:15:16 UTC (rev 188524)
+++ trunk/Source/WebKit/win/ChangeLog 2015-08-17 17:41:44 UTC (rev 188525)
@@ -1,3 +1,17 @@
+2015-08-17 Sungmann Cho <[email protected]>
+
+ [Win] Cleanups to PluginView::handleMouseEvent().
+ https://bugs.webkit.org/show_bug.cgi?id=148024
+
+ Reviewed by Alex Christensen.
+
+ 1. Replace the raw values identifying specific mouse buttons with
+ WebCore::MouseButton enum values.
+ 2. Reindent if and switch statements.
+
+ * Plugins/PluginViewWin.cpp:
+ (WebCore::PluginView::handleMouseEvent):
+
2015-08-13 Andy Estes <[email protected]>
[Cocoa] Downloads do not start if policy decision is made asynchronously
Modified: trunk/Source/WebKit/win/Plugins/PluginViewWin.cpp (188524 => 188525)
--- trunk/Source/WebKit/win/Plugins/PluginViewWin.cpp 2015-08-17 17:15:16 UTC (rev 188524)
+++ trunk/Source/WebKit/win/Plugins/PluginViewWin.cpp 2015-08-17 17:41:44 UTC (rev 188525)
@@ -617,47 +617,46 @@
if (event->shiftKey())
npEvent.wParam |= MK_SHIFT;
- if (event->type() == eventNames().mousemoveEvent ||
- event->type() == eventNames().mouseoutEvent ||
- event->type() == eventNames().mouseoverEvent) {
+ if (event->type() == eventNames().mousemoveEvent
+ || event->type() == eventNames().mouseoutEvent
+ || event->type() == eventNames().mouseoverEvent) {
npEvent.event = WM_MOUSEMOVE;
if (event->buttonDown())
switch (event->button()) {
- case LeftButton:
- npEvent.wParam |= MK_LBUTTON;
- break;
- case MiddleButton:
- npEvent.wParam |= MK_MBUTTON;
- break;
- case RightButton:
- npEvent.wParam |= MK_RBUTTON;
+ case LeftButton:
+ npEvent.wParam |= MK_LBUTTON;
break;
+ case MiddleButton:
+ npEvent.wParam |= MK_MBUTTON;
+ break;
+ case RightButton:
+ npEvent.wParam |= MK_RBUTTON;
+ break;
}
- }
- else if (event->type() == eventNames().mousedownEvent) {
+ } else if (event->type() == eventNames().mousedownEvent) {
focusPluginElement();
switch (event->button()) {
- case 0:
- npEvent.event = WM_LBUTTONDOWN;
- break;
- case 1:
- npEvent.event = WM_MBUTTONDOWN;
- break;
- case 2:
- npEvent.event = WM_RBUTTONDOWN;
- break;
+ case LeftButton:
+ npEvent.event = WM_LBUTTONDOWN;
+ break;
+ case MiddleButton:
+ npEvent.event = WM_MBUTTONDOWN;
+ break;
+ case RightButton:
+ npEvent.event = WM_RBUTTONDOWN;
+ break;
}
} else if (event->type() == eventNames().mouseupEvent) {
switch (event->button()) {
- case 0:
- npEvent.event = WM_LBUTTONUP;
- break;
- case 1:
- npEvent.event = WM_MBUTTONUP;
- break;
- case 2:
- npEvent.event = WM_RBUTTONUP;
- break;
+ case LeftButton:
+ npEvent.event = WM_LBUTTONUP;
+ break;
+ case MiddleButton:
+ npEvent.event = WM_MBUTTONUP;
+ break;
+ case RightButton:
+ npEvent.event = WM_RBUTTONUP;
+ break;
}
} else
return;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
