Title: [188533] trunk/Tools
- Revision
- 188533
- Author
- [email protected]
- Date
- 2015-08-17 12:45:11 -0700 (Mon, 17 Aug 2015)
Log Message
Refactor BuildbotQueueView._presentPopoverForPendingCommits to work more generically with
repositories other than "openSource" and "internal".
https://bugs.webkit.org/show_bug.cgi?id=147961
Patch by Jason Marcell <[email protected]> on 2015-08-17
Reviewed by Daniel Bates.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
(BuildbotQueueView.prototype._presentPopoverForPendingCommits): Refactored to work more
generically with repositories other than "openSource" and "internal".
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js (188532 => 188533)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js 2015-08-17 18:56:52 UTC (rev 188532)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js 2015-08-17 19:45:11 UTC (rev 188533)
@@ -153,22 +153,24 @@
var content = document.createElement("div");
content.className = "commit-history-popover";
- var webkitTrac = Dashboard.Repository.OpenSource.trac;
- var internalTrac = Dashboard.Repository.Internal.trac;
- var linesForOpenSource = this._popoverLinesForCommitRange(webkitTrac, queue.branch.openSource, latestProductiveIteration.revision[Dashboard.Repository.OpenSource.name] + 1, webkitTrac.latestRecordedRevisionNumber);
- for (var i = 0; i != linesForOpenSource.length; ++i)
- content.appendChild(linesForOpenSource[i]);
+ var shouldAddDivider = false;
+ var sortedRepositories = Dashboard.sortedRepositories;
+ for (var i = 0; i < sortedRepositories.length; ++i) {
+ var repository = sortedRepositories[i];
+ var trac = repository.trac;
+ var repositoryName = repository.name;
+ var latestProductiveRevisionNumber = latestProductiveIteration.revision[repositoryName];
+ if (!latestProductiveRevisionNumber || !trac.latestRecordedRevisionNumber)
+ continue;
+ var lines = this._popoverLinesForCommitRange(trac, queue.branch[repositoryName], latestProductiveRevisionNumber + 1, trac.latestRecordedRevisionNumber);
+ var length = lines.length;
+ if (length && shouldAddDivider)
+ this._addDividerToPopover(content);
+ for (var i = 0; i < length; ++i)
+ content.appendChild(lines[i]);
+ shouldAddDivider = shouldAddDivider || length > 0;
+ }
- var linesForInternal = [];
- if (latestProductiveIteration.revision[Dashboard.Repository.Internal.name] && internalTrac.latestRecordedRevisionNumber)
- var linesForInternal = this._popoverLinesForCommitRange(internalTrac, queue.branch.internal, latestProductiveIteration.revision[Dashboard.Repository.Internal.name] + 1, internalTrac.latestRecordedRevisionNumber);
-
- if (linesForOpenSource.length && linesForInternal.length)
- this._addDividerToPopover(content);
-
- for (var i = 0; i != linesForInternal.length; ++i)
- content.appendChild(linesForInternal[i]);
-
var rect = Dashboard.Rect.rectFromClientRect(element.getBoundingClientRect());
popover.content = content;
popover.present(rect, [Dashboard.RectEdge.MIN_Y, Dashboard.RectEdge.MAX_Y, Dashboard.RectEdge.MAX_X, Dashboard.RectEdge.MIN_X]);
Modified: trunk/Tools/ChangeLog (188532 => 188533)
--- trunk/Tools/ChangeLog 2015-08-17 18:56:52 UTC (rev 188532)
+++ trunk/Tools/ChangeLog 2015-08-17 19:45:11 UTC (rev 188533)
@@ -1,3 +1,15 @@
+2015-08-17 Jason Marcell <[email protected]>
+
+ Refactor BuildbotQueueView._presentPopoverForPendingCommits to work more generically with
+ repositories other than "openSource" and "internal".
+ https://bugs.webkit.org/show_bug.cgi?id=147961
+
+ Reviewed by Daniel Bates.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
+ (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Refactored to work more
+ generically with repositories other than "openSource" and "internal".
+
2015-08-17 Alexey Proskuryakov <[email protected]>
build.webkit.org/dashboard shows yellow when crash-only queues have too many failures
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
