Title: [188573] trunk/Source/WebInspectorUI
- Revision
- 188573
- Author
- drou...@apple.com
- Date
- 2015-08-17 21:13:56 -0700 (Mon, 17 Aug 2015)
Log Message
Web Inspector: font-family list is backwards in visual sidebar
https://bugs.webkit.org/show_bug.cgi?id=148101
Reviewed by Timothy Hatcher.
* UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.js:
(WebInspector.VisualStyleCommaSeparatedKeywordEditor.prototype._addCommaSeparatedKeyword):
Now appends new children if the current index is not set instead of inserting them.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (188572 => 188573)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-08-18 04:12:15 UTC (rev 188572)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-08-18 04:13:56 UTC (rev 188573)
@@ -1,5 +1,16 @@
2015-08-17 Devin Rousso <drou...@apple.com>
+ Web Inspector: font-family list is backwards in visual sidebar
+ https://bugs.webkit.org/show_bug.cgi?id=148101
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.js:
+ (WebInspector.VisualStyleCommaSeparatedKeywordEditor.prototype._addCommaSeparatedKeyword):
+ Now appends new children if the current index is not set instead of inserting them.
+
+2015-08-17 Devin Rousso <drou...@apple.com>
+
Web Inspector: Style changes to Visual sidebar selector items
https://bugs.webkit.org/show_bug.cgi?id=148114
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.js (188572 => 188573)
--- trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.js 2015-08-18 04:12:15 UTC (rev 188572)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.js 2015-08-18 04:13:56 UTC (rev 188573)
@@ -171,8 +171,11 @@
_addCommaSeparatedKeyword(value, index)
{
let valueElement = this._createNewTreeElement(value);
- let indexIsSet = !isNaN(index);
- this._commaSeparatedKeywords.insertChild(valueElement, indexIsSet ? index + !this._insertNewItemsBeforeSelected : 0);
+ if (!isNaN(index))
+ this._commaSeparatedKeywords.insertChild(valueElement, index + !this._insertNewItemsBeforeSelected);
+ else
+ this._commaSeparatedKeywords.appendChild(valueElement);
+
return valueElement;
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
