Title: [188655] trunk/Source/WebInspectorUI
- Revision
- 188655
- Author
- commit-qu...@webkit.org
- Date
- 2015-08-19 15:30:04 -0700 (Wed, 19 Aug 2015)
Log Message
Web Inspector: Uncaught exception in inspector page while handling event DOMStorage.domStorageItemRemoved
https://bugs.webkit.org/show_bug.cgi?id=148191
Patch by Joseph Pecoraro <pecor...@apple.com> on 2015-08-19
Reviewed by Brian Burg.
* UserInterface/Controllers/StorageManager.js:
(WebInspector.StorageManager.prototype.itemsCleared):
(WebInspector.StorageManager.prototype.itemRemoved):
(WebInspector.StorageManager.prototype.itemAdded):
(WebInspector.StorageManager.prototype.itemUpdated):
Check if the DOMStorage for the identifier actually exists.
Due to how the backend emits events, the page may have already
navigated when we get a storage update for the previous page.
In that case, we don't want to create a DOMStorage for the
previous page if it doesn't exist.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (188654 => 188655)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-08-19 22:26:29 UTC (rev 188654)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-08-19 22:30:04 UTC (rev 188655)
@@ -1,3 +1,21 @@
+2015-08-19 Joseph Pecoraro <pecor...@apple.com>
+
+ Web Inspector: Uncaught exception in inspector page while handling event DOMStorage.domStorageItemRemoved
+ https://bugs.webkit.org/show_bug.cgi?id=148191
+
+ Reviewed by Brian Burg.
+
+ * UserInterface/Controllers/StorageManager.js:
+ (WebInspector.StorageManager.prototype.itemsCleared):
+ (WebInspector.StorageManager.prototype.itemRemoved):
+ (WebInspector.StorageManager.prototype.itemAdded):
+ (WebInspector.StorageManager.prototype.itemUpdated):
+ Check if the DOMStorage for the identifier actually exists.
+ Due to how the backend emits events, the page may have already
+ navigated when we get a storage update for the previous page.
+ In that case, we don't want to create a DOMStorage for the
+ previous page if it doesn't exist.
+
2015-08-19 Brian Burg <bb...@apple.com>
Web Inspector: use unprefixed CSS property 'filter' instead of '-webkit-filter'
Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/StorageManager.js (188654 => 188655)
--- trunk/Source/WebInspectorUI/UserInterface/Controllers/StorageManager.js 2015-08-19 22:26:29 UTC (rev 188654)
+++ trunk/Source/WebInspectorUI/UserInterface/Controllers/StorageManager.js 2015-08-19 22:30:04 UTC (rev 188655)
@@ -106,22 +106,30 @@
itemsCleared(storageId)
{
- this._domStorageForIdentifier(storageId).itemsCleared(storageId);
+ let domStorage = this._domStorageForIdentifier(storageId);
+ if (domStorage)
+ domStorage.itemsCleared(storageId);
}
itemRemoved(storageId, key)
{
- this._domStorageForIdentifier(storageId).itemRemoved(key);
+ let domStorage = this._domStorageForIdentifier(storageId);
+ if (domStorage)
+ domStorage.itemRemoved(key);
}
itemAdded(storageId, key, value)
{
- this._domStorageForIdentifier(storageId).itemAdded(key, value);
+ let domStorage = this._domStorageForIdentifier(storageId);
+ if (domStorage)
+ domStorage.itemAdded(key, value);
}
itemUpdated(storageId, key, oldValue, value)
{
- this._domStorageForIdentifier(storageId).itemUpdated(key, oldValue, value);
+ let domStorage = this._domStorageForIdentifier(storageId);
+ if (domStorage)
+ domStorage.itemUpdated(key, oldValue, value);
}
inspectDatabase(id)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
