Title: [188682] trunk/Source/WebInspectorUI
- Revision
- 188682
- Author
- drou...@apple.com
- Date
- 2015-08-19 22:03:06 -0700 (Wed, 19 Aug 2015)
Log Message
Web Inspector: Visual styles panel does not work with pseudo-elements
https://bugs.webkit.org/show_bug.cgi?id=148187
Reviewed by Timothy Hatcher.
If the inline style does not exist, such as for pseudo-elements, default to the first matched rule.
* UserInterface/Views/VisualStyleSelectorSection.js:
(WebInspector.VisualStyleSelectorSection.prototype.update):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (188681 => 188682)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-08-20 04:43:24 UTC (rev 188681)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-08-20 05:03:06 UTC (rev 188682)
@@ -1,3 +1,15 @@
+2015-08-19 Devin Rousso <drou...@apple.com>
+
+ Web Inspector: Visual styles panel does not work with pseudo-elements
+ https://bugs.webkit.org/show_bug.cgi?id=148187
+
+ Reviewed by Timothy Hatcher.
+
+ If the inline style does not exist, such as for pseudo-elements, default to the first matched rule.
+
+ * UserInterface/Views/VisualStyleSelectorSection.js:
+ (WebInspector.VisualStyleSelectorSection.prototype.update):
+
2015-08-19 Joseph Pecoraro <pecor...@apple.com>
Web Inspector: DOMTree leaks on main resource changes
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleSelectorSection.js (188681 => 188682)
--- trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleSelectorSection.js 2015-08-20 04:43:24 UTC (rev 188681)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleSelectorSection.js 2015-08-20 05:03:06 UTC (rev 188682)
@@ -155,11 +155,14 @@
}
}
- if (!this._nodeStyles[WebInspector.VisualStyleSelectorSection.LastSelectedRuleSymbol])
- this._nodeStyles[WebInspector.VisualStyleSelectorSection.LastSelectedRuleSymbol] = this._nodeStyles.inlineStyle;
+ if (this._nodeStyles.inlineStyle) {
+ if (!this._nodeStyles[WebInspector.VisualStyleSelectorSection.LastSelectedRuleSymbol])
+ this._nodeStyles[WebInspector.VisualStyleSelectorSection.LastSelectedRuleSymbol] = this._nodeStyles.inlineStyle;
- // Inline Style
- createSelectorItem.call(this, this._nodeStyles.inlineStyle, WebInspector.UIString("This Element"));
+ // Inline Style
+ createSelectorItem.call(this, this._nodeStyles.inlineStyle, WebInspector.UIString("This Element"));
+ } else if (!this._nodeStyles[WebInspector.VisualStyleSelectorSection.LastSelectedRuleSymbol])
+ this._nodeStyles[WebInspector.VisualStyleSelectorSection.LastSelectedRuleSymbol] = this._nodeStyles.matchedRules[0].style;
// Matched Rules
for (let rule of uniqueOrderedRules(this._nodeStyles.matchedRules)) {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
